mirror of
https://github.com/uwol/proleap-vb6-parser.git
synced 2025-12-18 12:34:35 +03:00
contribution
This commit is contained in:
@@ -6,16 +6,15 @@ This open source repository is maintained by [@uwol](https://github.com/uwol).
|
|||||||
|
|
||||||
## Contributing code
|
## Contributing code
|
||||||
|
|
||||||
1. Please fork the repo. Make your changes on your fork.
|
1. Please fork the repo. Make your changes on your fork. In case of new features, please include a unit test. Please fill out the contributor agreement in [`.github/contributors/`](/.github/contributors).
|
||||||
- In case of new features, please include a unit test.
|
|
||||||
- Please fill out the contributor agreement in [`.github/contributors/`](/.github/contributors)
|
|
||||||
2. Make sure, that the build and all tests pass: `$ mvn clean test`
|
2. Make sure, that the build and all tests pass: `$ mvn clean test`
|
||||||
3. Finally, please issue a pull request.
|
3. Finally, please issue a pull request.
|
||||||
|
|
||||||
We will review the PR for:
|
We will review the PR for:
|
||||||
- Relevant functionality for a parser
|
- Relevant functionality for a parser.
|
||||||
- Passing test suite
|
- Passing test suite.
|
||||||
- Clean code, code quality
|
- Clean code, code quality.
|
||||||
|
- Contributor agreement in [`.github/contributors/`](/.github/contributors).
|
||||||
|
|
||||||
In review, we support you with code and suggestions. Finally, PR is merged.
|
In review, we support you with code and suggestions. Finally, PR is merged.
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user