From fd8ddacfae9a15074245995c9ef05d39de5d9463 Mon Sep 17 00:00:00 2001 From: uwol Date: Fri, 22 Dec 2017 10:02:44 +0100 Subject: [PATCH] contribution --- CONTRIBUTING.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6781d74..8a6734f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,16 +6,15 @@ This open source repository is maintained by [@uwol](https://github.com/uwol). ## Contributing code -1. Please fork the repo. Make your changes on your fork. - - In case of new features, please include a unit test. - - Please fill out the contributor agreement in [`.github/contributors/`](/.github/contributors) +1. Please fork the repo. Make your changes on your fork. In case of new features, please include a unit test. Please fill out the contributor agreement in [`.github/contributors/`](/.github/contributors). 2. Make sure, that the build and all tests pass: `$ mvn clean test` 3. Finally, please issue a pull request. We will review the PR for: -- Relevant functionality for a parser -- Passing test suite -- Clean code, code quality +- Relevant functionality for a parser. +- Passing test suite. +- Clean code, code quality. +- Contributor agreement in [`.github/contributors/`](/.github/contributors). In review, we support you with code and suggestions. Finally, PR is merged.