Use override instead of virtual on destructors

In addition, fixed a potential fall-through in x86:Assembler.
This commit is contained in:
kobalicek
2023-10-06 23:04:08 +02:00
parent 4413d78c98
commit 6e71f6be0c
15 changed files with 16 additions and 15 deletions

View File

@@ -27,7 +27,7 @@ public:
//! \{
ASMJIT_API Assembler(CodeHolder* code = nullptr) noexcept;
ASMJIT_API virtual ~Assembler() noexcept;
ASMJIT_API ~Assembler() noexcept override;
//! \}

View File

@@ -29,7 +29,7 @@ public:
//! \{
ASMJIT_API explicit Builder(CodeHolder* code = nullptr) noexcept;
ASMJIT_API virtual ~Builder() noexcept;
ASMJIT_API ~Builder() noexcept override;
//! \}

View File

@@ -30,7 +30,7 @@ public:
//! \{
ASMJIT_API explicit Compiler(CodeHolder* code = nullptr) noexcept;
ASMJIT_API virtual ~Compiler() noexcept;
ASMJIT_API ~Compiler() noexcept override;
//! \}

View File

@@ -37,7 +37,7 @@ public:
//! \{
ARMRAPass() noexcept;
virtual ~ARMRAPass() noexcept;
~ARMRAPass() noexcept override;
//! \}

View File

@@ -45,7 +45,7 @@ public:
//! Creates a new `BaseAssembler` instance.
ASMJIT_API BaseAssembler() noexcept;
//! Destroys the `BaseAssembler` instance.
ASMJIT_API virtual ~BaseAssembler() noexcept;
ASMJIT_API ~BaseAssembler() noexcept override;
//! \}

View File

@@ -223,7 +223,7 @@ public:
//! Creates a new `BaseBuilder` instance.
ASMJIT_API BaseBuilder() noexcept;
//! Destroys the `BaseBuilder` instance.
ASMJIT_API virtual ~BaseBuilder() noexcept;
ASMJIT_API ~BaseBuilder() noexcept override;
//! \}

View File

@@ -77,7 +77,7 @@ public:
//! Creates a new `BaseCompiler` instance.
ASMJIT_API BaseCompiler() noexcept;
//! Destroys the `BaseCompiler` instance.
ASMJIT_API virtual ~BaseCompiler() noexcept;
ASMJIT_API ~BaseCompiler() noexcept override;
//! \}

View File

@@ -35,7 +35,7 @@ public:
//! Creates a `JitRuntime` instance.
ASMJIT_API explicit JitRuntime(const JitAllocator::CreateParams* params = nullptr) noexcept;
//! Destroys the `JitRuntime` instance.
ASMJIT_API virtual ~JitRuntime() noexcept;
ASMJIT_API ~JitRuntime() noexcept override;
ASMJIT_INLINE_NODEBUG void reset(ResetPolicy resetPolicy = ResetPolicy::kSoft) noexcept {
_allocator.reset(resetPolicy);

View File

@@ -119,7 +119,7 @@ public:
//! Creates a new `FileLogger` that logs to `FILE*`.
ASMJIT_API FileLogger(FILE* file = nullptr) noexcept;
//! Destroys the `FileLogger`.
ASMJIT_API virtual ~FileLogger() noexcept;
ASMJIT_API ~FileLogger() noexcept override;
//! \}
@@ -155,7 +155,7 @@ public:
//! Create new `StringLogger`.
ASMJIT_API StringLogger() noexcept;
//! Destroys the `StringLogger`.
ASMJIT_API virtual ~StringLogger() noexcept;
ASMJIT_API ~StringLogger() noexcept override;
//! \}

View File

@@ -754,7 +754,7 @@ public:
//! \{
BaseRAPass() noexcept;
virtual ~BaseRAPass() noexcept;
~BaseRAPass() noexcept override;
//! \}

View File

@@ -3017,6 +3017,7 @@ CaseExtRm:
rmRel = &o0;
goto EmitVexEvexM;
}
break;
case InstDB::kEncodingVexMri_Lx:
opcode |= x86OpcodeLBySize(o0.x86RmSize() | o1.x86RmSize());

View File

@@ -642,7 +642,7 @@ public:
//! \{
ASMJIT_API explicit Assembler(CodeHolder* code = nullptr) noexcept;
ASMJIT_API virtual ~Assembler() noexcept;
ASMJIT_API ~Assembler() noexcept override;
//! \}

View File

@@ -326,7 +326,7 @@ public:
//! \{
ASMJIT_API explicit Builder(CodeHolder* code = nullptr) noexcept;
ASMJIT_API virtual ~Builder() noexcept;
ASMJIT_API ~Builder() noexcept override;
//! \}

View File

@@ -494,7 +494,7 @@ public:
//! \{
ASMJIT_API explicit Compiler(CodeHolder* code = nullptr) noexcept;
ASMJIT_API virtual ~Compiler() noexcept;
ASMJIT_API ~Compiler() noexcept override;
//! \}

View File

@@ -36,7 +36,7 @@ public:
//! \{
X86RAPass() noexcept;
virtual ~X86RAPass() noexcept;
~X86RAPass() noexcept override;
//! \}