Commit Graph

2043 Commits

Author SHA1 Message Date
Andrey Sikorin
728ed7c65f Fix Adobe and CERT links (#1971) 2022-09-13 11:15:12 -04:00
tocic
4ec7e81ecb Fix typos (#1970) 2022-09-11 23:52:09 -04:00
Sergey Zubkov
9d28e32999 C.87: fix missing access specifiers (closes #1957) 2022-08-08 15:39:14 -04:00
Sergey Zubkov
9a95f97f44 C.168: switch example to op+ to avoid side tracking about defaults (closes #1955) 2022-08-08 15:19:42 -04:00
Sergey Zubkov
0a7d70851c F.17: note about passing reference wrappers by value (issue #1948) 2022-08-08 15:11:33 -04:00
Daniel Kříž
6476b15070 SF.5: prefer relative import to absolute one (#1944)
Signed-off-by: Daniel Kříž <Daniel.kriz@protonmail.com>
2022-08-08 09:10:57 -07:00
Niels Dekker
1aafa24880 E.15 Clarify when a rethrow would slice to std::exception (#1949)
Avoided a potential misunderstanding that `throw e` would slice *any* `e` to `std::exception`.

The note about rethrowing appears to be written when the example of this item still did `catch (const exception& e)`, which was prior to commit d568d190f6, "Generalized E.15, closes #1848".
2022-08-08 09:09:41 -07:00
Nikolay Panov
be1722ad0c [#1946] T.65 Fix two typos (#1956)
Fixes #1946:
 - copy_trait type argument needs to be a container element type.
   Use Value_type<Iter> like in other examples.

 - Fix name typo in the definition of copy_helper.
2022-08-08 09:08:45 -07:00
Baiyan Huang
444704f703 C.168 Fix code example (#1954) 2022-08-05 08:53:47 -04:00
Nikolay Panov
dca24a0379 T.21 Fix wrong return type (#1942)
Co-authored-by: Nikolay Panov <pn.interface@gmail.com>
2022-08-02 12:30:21 -04:00
bgloyer
6f27719b2b C.64 Minor fix to make example compile (#1939) 2022-07-18 21:52:16 -04:00
Sergey Zubkov
4b8b2819b9 C.32: amend merged PR per call notes. It overlaps R.3 quite a bit 2022-07-13 14:19:39 -04:00
Sergey Zubkov
2b05a48a05 F.1 drop invalid line closes #1928 2022-07-13 12:36:52 -04:00
bgloyer
cbf455407e Clean up and add example for C.32 - raw pointers (#1909)
* Update CppCoreGuidelines.md

* Update CppCoreGuidelines.md

* Update isocpp.dic

* use snake casing

* sake case naming

* C 32 comments (#3)

* F.16 ("in" parameters): Move Matrix example to F.20 (return values) (#1922)

The `Matrix` example and the notes about assignment appear off-topic in rule F.16, as F.16 is specifically about "in" parameters.

With help from Sergey Zubkov.

* SL.io.50 (Avoid `endl`): Mention string streams (#1920)

Explicitly mentioned string streams as `endl` insertions into string streams do actually occur in the wild.

With help from Sergey Zubkov.

* Extended E.16 to include copy ctor for exception type, closes #1921

* Fix GitHub Actions build warnings, Marker style should be `*` (#1925)

* restored reference

* Added references to note

Co-authored-by: Niels Dekker <N.Dekker@lumc.nl>
Co-authored-by: Herb Sutter <herb.sutter@gmail.com>

Co-authored-by: Niels Dekker <N.Dekker@lumc.nl>
Co-authored-by: Herb Sutter <herb.sutter@gmail.com>
2022-07-13 09:23:14 -07:00
Ankur Satle
f2e9b5c2ac Issue #1931: C++20 wasn't included in "modern C++" (#1932)
* Issue #1931 - Include C++20 as 'modern C++'

* "modern C++" means C++11 and newer
2022-07-13 09:06:56 -07:00
Gábor Szeder
42c4cc6a75 E.19: clarify that finally is from the GSL (#1936)
When I stumbled upon E.19 "Use a `final_action` object to express
cleanup if no suitable resource handle is available" I was hopeful
that this `final_action`/`finally()` thing is from the STL, but, alas,
it isn't.

Make it clear that `finally` is a GSL construct.
2022-07-13 09:05:36 -07:00
Sven van Haastregt
fde9ee5de1 C.9: Improve an inline link (#1933)
Avoid ending the sentence with a dangling "see".
2022-07-07 09:04:59 -04:00
Francisco Moretti
6d018fcf5f C.166: Use markdown format and document title for link (#1929) 2022-06-25 14:53:25 -04:00
Niels Dekker
81dfb4814d Fix GitHub Actions build warnings, Marker style should be * (#1925) 2022-06-15 10:01:28 -04:00
Herb Sutter
d5907d6dd5 Extended E.16 to include copy ctor for exception type, closes #1921 2022-06-13 13:14:54 -07:00
Niels Dekker
9ead2c44b4 SL.io.50 (Avoid endl): Mention string streams (#1920)
Explicitly mentioned string streams as `endl` insertions into string streams do actually occur in the wild.

With help from Sergey Zubkov.
2022-06-13 09:11:50 -07:00
Niels Dekker
a534f4a168 F.16 ("in" parameters): Move Matrix example to F.20 (return values) (#1922)
The `Matrix` example and the notes about assignment appear off-topic in rule F.16, as F.16 is specifically about "in" parameters.

With help from Sergey Zubkov.
2022-06-13 09:09:54 -07:00
Markus Hofbauer
ddef6cdbae Move F.60 to align with TOC (#1914) 2022-05-19 17:05:04 -04:00
Sergey Zubkov
e30543d06a NL dropping parenthesized bit, per commit comment 2022-05-07 23:02:44 -04:00
Sergey Zubkov
697a78b4f4 NL: rules-> suggestsions (closes #1906) 2022-05-05 16:19:56 -04:00
Sergey Zubkov
dc8f95d608 F.46: add note regarding the return of main (see #1896) 2022-04-07 16:54:17 -04:00
Sergey Zubkov
4a386f0a65 [SF.21] adjust per editors call 2022-04-07 16:21:10 -04:00
bgloyer
0db2b88c57 Added example for SF.21 (#1890)
* Example for SF.21

* Update isocpp.dic

* remove space

* revert isocpp.dic change
2022-04-07 13:20:49 -07:00
William So
d9d985a9f6 [C.148] Fix 1 anchor link (#1904) 2022-04-05 16:17:56 -04:00
Sergey Zubkov
66bdbf1a90 modernizing concepts (#1883) 2022-04-03 11:41:41 -04:00
Werner Henze
df6787f651 formatting typo (#1895)
Co-authored-by: Werner Henze <w.henze@avm.de>
2022-03-09 13:43:31 -05:00
Sandor DARGO
afa6f73f1a formatting: Updates to I.4 (#1891) 2022-02-22 11:21:20 -05:00
apenn-msft
ead60212f3 conditionally unused parameters can be declared using maybe_unused attribute. (#1863)
* conditionally unused parameters can be declared using maybe_unused attribute.

* move to Notes and add example

* whitespace?

* ok got the whitespace

* adjust example
2022-02-10 13:34:32 -08:00
al-mission-2016
eb2f4d7756 code formating fix: +1 new line (#1888)
One more new line is necessary after the text "Return statements in a case label are also OK:" to make the code excerpt after it be formatted as code.
2022-02-06 23:07:30 -05:00
Michael B. Price
e92886217c Adding .DS_Store to the .gitignore file since MacOS loves touching those files. (#1886) 2022-02-03 22:16:40 -05:00
Michael B. Price
256e6a939f Remove irrelevant source file mistakenly committed (#1885) 2022-02-03 16:22:03 -05:00
Sergey Zubkov
e01a72ee93 make two more mentions of supported standards agree with the Abstract 2022-01-28 01:38:17 -05:00
bgloyer
43f2e34148 E.14 exception type examples for #1852 (#1857)
* E.14

* clean-up

* add final

* Added words to dictionary

* cleanup

* fix typo

* Update CppCoreGuidelines.md
2022-01-27 13:10:34 -08:00
Sergey Zubkov
369beb8a0c make other mentions of supported standards agree with the Abstract 2022-01-21 00:47:39 -05:00
Hyuk Myeong
1a57ff0226 Fixed typos (#1876) 2022-01-20 13:10:52 -08:00
Melroy van den Berg
5f393d53af Promote C++20 (#1880)
The documentation still mentions C++17, while C++20 is already out for some time. So I updated the introduction paragraphs.
2022-01-17 00:00:25 -05:00
Sergey Zubkov
171fda3597 F.7: de-lowercase two lines 2022-01-06 23:26:42 -05:00
Ryan A. Pavlik
ba12aca973 Fix broken cross-references. (#1878) 2022-01-06 23:24:22 -05:00
Sergey Zubkov
11cc4c4775 E.15: typo in title 2022-01-05 10:03:44 -05:00
Sergey Zubkov
fdbaff2bf7 [CP.2] link CP.102 list of books and add Herlihy-Shavit
closes #1725
2022-01-03 17:04:49 -05:00
Sergey Zubkov
ce5341b02d merge ES.74 into ES.6, leaving a redirect behind
closes #1858
2022-01-03 16:50:16 -05:00
Kevin Boyette
dc6ea376c4 ES.48: fix wording in reasoning (#1859) 2021-11-30 23:14:38 -05:00
oleksandrkozlov
b6d7ab64ad C.130: drop a destructor in the D class (#1855)
To follow the Rule of Zero.
2021-11-18 13:08:34 -08:00
Sergey Zubkov
620cf6278e C.130: drop final from last commit per meeting notes 2021-11-11 16:13:12 -05:00
bgloyer
86a42c29fc Update CppCoreGuidelines.md (#1851) 2021-11-11 16:11:36 -05:00