mirror of
https://github.com/isocpp/CppCoreGuidelines.git
synced 2025-12-18 05:04:41 +03:00
Merge pull request #1164 from ChrisGuzak/ChrisGuzak-sizeof-not_max
use sizeof(buffer) instead of MAX
This commit is contained in:
@@ -1584,7 +1584,7 @@ Consider a famous security bug:
|
||||
{
|
||||
char buffer[MAX];
|
||||
// ...
|
||||
memset(buffer, 0, MAX);
|
||||
memset(buffer, 0, sizeof(buffer));
|
||||
}
|
||||
|
||||
There was no postcondition stating that the buffer should be cleared and the optimizer eliminated the apparently redundant `memset()` call:
|
||||
@@ -1593,7 +1593,7 @@ There was no postcondition stating that the buffer should be cleared and the opt
|
||||
{
|
||||
char buffer[MAX];
|
||||
// ...
|
||||
memset(buffer, 0, MAX);
|
||||
memset(buffer, 0, sizeof(buffer));
|
||||
Ensures(buffer[0] == 0);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user