mirror of
https://github.com/stashapp/stash.git
synced 2025-12-18 04:44:37 +03:00
* Don't capitalize local variables
ValidCodecs -> validCodecs
* Capitalize deprecation markers
A deprecated marker should be capitalized.
* Use re.MustCompile for static regexes
If the regex fails to compile, it's a programmer error, and should be
treated as such. The regex is entirely static.
* Simplify else-if constructions
Rewrite
else { if cond {}}
to
else if cond {}
* Use a switch statement to analyze formats
Break an if-else chain. While here, simplify code flow.
Also introduce a proper static error for unsupported image formats,
paving the way for being able to check against the error.
* Rewrite ifElse chains into switch statements
The "Effective Go" https://golang.org/doc/effective_go#switch document
mentions it is more idiomatic to write if-else chains as switches when
it is possible.
Find all the plain rewrite occurrences in the code base and rewrite.
In some cases, the if-else chains are replaced by a switch scrutinizer.
That is, the code sequence
if x == 1 {
..
} else if x == 2 {
..
} else if x == 3 {
...
}
can be rewritten into
switch x {
case 1:
..
case 2:
..
case 3:
..
}
which is clearer for the compiler: it can decide if the switch is
better served by a jump-table then a branch-chain.
* Rewrite switches, introduce static errors
Introduce two new static errors:
* `ErrNotImplmented`
* `ErrNotSupported`
And use these rather than forming new generative errors whenever the
code is called. Code can now test on the errors (since they are static
and the pointers to them wont change).
Also rewrite ifElse chains into switches in this part of the code base.
* Introduce a StashBoxError in configuration
Since all stashbox errors are the same, treat them as such in the code
base. While here, rewrite an ifElse chain.
In the future, it might be beneifical to refactor configuration errors
into one error which can handle missing fields, which context the error
occurs in and so on. But for now, try to get an overview of the error
categories by hoisting them into static errors.
* Get rid of an else-block in transaction handling
If we succesfully `recover()`, we then always `panic()`. This means the
rest of the code is not reachable, so we can avoid having an else-block
here.
It also solves an ifElse-chain style check in the code base.
* Use strings.ReplaceAll
Rewrite
strings.Replace(s, o, n, -1)
into
strings.ReplaceAll(s, o, n)
To make it consistent and clear that we are doing an all-replace in the
string rather than replacing parts of it. It's more of a nitpick since
there are no implementation differences: the stdlib implementation is
just to supply -1.
* Rewrite via gocritic's assignOp
Statements of the form
x = x + e
is rewritten into
x += e
where applicable.
* Formatting
* Review comments handled
Stash-box is a proper noun.
Rewrite a switch into an if-chain which returns on the first error
encountered.
* Use context.TODO() over context.Background()
Patch in the same vein as everything else: use the TODO() marker so we
can search for it later and link it into the context tree/tentacle once
it reaches down to this level in the code base.
* Tell the linter to ignore a section in manager_tasks.go
The section is less readable, so mark it with a nolint for now. Because
the rewrite enables a ifElseChain, also mark that as nolint for now.
* Use strings.ReplaceAll over strings.Replace
* Apply an ifElse rewrite
else { if .. { .. } } rewrite into else if { .. }
* Use switch-statements over ifElseChains
Rewrite chains of if-else into switch statements. Where applicable,
add an early nil-guard to simplify case analysis. Also, in
ScanTask's Start(..), invert the logic to outdent the whole block, and
help the reader: if it's not a scene, the function flow is now far more
local to the top of the function, and it's clear that the rest of the
function has to do with scene management.
* Enable gocritic on the code base.
Disable appendAssign for now since we aren't passing that check yet.
* Document the nolint additions
* Document StashBoxBatchPerformerTagInput
352 lines
10 KiB
Go
352 lines
10 KiB
Go
package sqlite
|
|
|
|
import (
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/stashapp/stash/pkg/models"
|
|
)
|
|
|
|
const movieTable = "movies"
|
|
const movieIDColumn = "movie_id"
|
|
|
|
type movieQueryBuilder struct {
|
|
repository
|
|
}
|
|
|
|
func NewMovieReaderWriter(tx dbi) *movieQueryBuilder {
|
|
return &movieQueryBuilder{
|
|
repository{
|
|
tx: tx,
|
|
tableName: movieTable,
|
|
idColumn: idColumn,
|
|
},
|
|
}
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) Create(newObject models.Movie) (*models.Movie, error) {
|
|
var ret models.Movie
|
|
if err := qb.insertObject(newObject, &ret); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &ret, nil
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) Update(updatedObject models.MoviePartial) (*models.Movie, error) {
|
|
const partial = true
|
|
if err := qb.update(updatedObject.ID, updatedObject, partial); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return qb.Find(updatedObject.ID)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) UpdateFull(updatedObject models.Movie) (*models.Movie, error) {
|
|
const partial = false
|
|
if err := qb.update(updatedObject.ID, updatedObject, partial); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return qb.Find(updatedObject.ID)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) Destroy(id int) error {
|
|
return qb.destroyExisting([]int{id})
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) Find(id int) (*models.Movie, error) {
|
|
var ret models.Movie
|
|
if err := qb.get(id, &ret); err != nil {
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil, nil
|
|
}
|
|
return nil, err
|
|
}
|
|
return &ret, nil
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) FindMany(ids []int) ([]*models.Movie, error) {
|
|
var movies []*models.Movie
|
|
for _, id := range ids {
|
|
movie, err := qb.Find(id)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if movie == nil {
|
|
return nil, fmt.Errorf("movie with id %d not found", id)
|
|
}
|
|
|
|
movies = append(movies, movie)
|
|
}
|
|
|
|
return movies, nil
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) FindByName(name string, nocase bool) (*models.Movie, error) {
|
|
query := "SELECT * FROM movies WHERE name = ?"
|
|
if nocase {
|
|
query += " COLLATE NOCASE"
|
|
}
|
|
query += " LIMIT 1"
|
|
args := []interface{}{name}
|
|
return qb.queryMovie(query, args)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) FindByNames(names []string, nocase bool) ([]*models.Movie, error) {
|
|
query := "SELECT * FROM movies WHERE name"
|
|
if nocase {
|
|
query += " COLLATE NOCASE"
|
|
}
|
|
query += " IN " + getInBinding(len(names))
|
|
var args []interface{}
|
|
for _, name := range names {
|
|
args = append(args, name)
|
|
}
|
|
return qb.queryMovies(query, args)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) Count() (int, error) {
|
|
return qb.runCountQuery(qb.buildCountQuery("SELECT movies.id FROM movies"), nil)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) All() ([]*models.Movie, error) {
|
|
return qb.queryMovies(selectAll("movies")+qb.getMovieSort(nil), nil)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) makeFilter(movieFilter *models.MovieFilterType) *filterBuilder {
|
|
query := &filterBuilder{}
|
|
|
|
query.handleCriterion(stringCriterionHandler(movieFilter.Name, "movies.name"))
|
|
query.handleCriterion(stringCriterionHandler(movieFilter.Director, "movies.director"))
|
|
query.handleCriterion(stringCriterionHandler(movieFilter.Synopsis, "movies.synopsis"))
|
|
query.handleCriterion(intCriterionHandler(movieFilter.Rating, "movies.rating"))
|
|
query.handleCriterion(durationCriterionHandler(movieFilter.Duration, "movies.duration"))
|
|
query.handleCriterion(movieIsMissingCriterionHandler(qb, movieFilter.IsMissing))
|
|
query.handleCriterion(stringCriterionHandler(movieFilter.URL, "movies.url"))
|
|
query.handleCriterion(movieStudioCriterionHandler(qb, movieFilter.Studios))
|
|
query.handleCriterion(moviePerformersCriterionHandler(qb, movieFilter.Performers))
|
|
|
|
return query
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) Query(movieFilter *models.MovieFilterType, findFilter *models.FindFilterType) ([]*models.Movie, int, error) {
|
|
if findFilter == nil {
|
|
findFilter = &models.FindFilterType{}
|
|
}
|
|
if movieFilter == nil {
|
|
movieFilter = &models.MovieFilterType{}
|
|
}
|
|
|
|
query := qb.newQuery()
|
|
|
|
query.body = selectDistinctIDs("movies")
|
|
|
|
if q := findFilter.Q; q != nil && *q != "" {
|
|
searchColumns := []string{"movies.name"}
|
|
clause, thisArgs := getSearchBinding(searchColumns, *q, false)
|
|
query.addWhere(clause)
|
|
query.addArg(thisArgs...)
|
|
}
|
|
|
|
filter := qb.makeFilter(movieFilter)
|
|
|
|
query.addFilter(filter)
|
|
|
|
query.sortAndPagination = qb.getMovieSort(findFilter) + getPagination(findFilter)
|
|
idsResult, countResult, err := query.executeFind()
|
|
if err != nil {
|
|
return nil, 0, err
|
|
}
|
|
|
|
var movies []*models.Movie
|
|
for _, id := range idsResult {
|
|
movie, err := qb.Find(id)
|
|
if err != nil {
|
|
return nil, 0, err
|
|
}
|
|
|
|
movies = append(movies, movie)
|
|
}
|
|
|
|
return movies, countResult, nil
|
|
}
|
|
|
|
func movieIsMissingCriterionHandler(qb *movieQueryBuilder, isMissing *string) criterionHandlerFunc {
|
|
return func(f *filterBuilder) {
|
|
if isMissing != nil && *isMissing != "" {
|
|
switch *isMissing {
|
|
case "front_image":
|
|
f.addJoin("movies_images", "", "movies_images.movie_id = movies.id")
|
|
f.addWhere("movies_images.front_image IS NULL")
|
|
case "back_image":
|
|
f.addJoin("movies_images", "", "movies_images.movie_id = movies.id")
|
|
f.addWhere("movies_images.back_image IS NULL")
|
|
case "scenes":
|
|
f.addJoin("movies_scenes", "", "movies_scenes.movie_id = movies.id")
|
|
f.addWhere("movies_scenes.scene_id IS NULL")
|
|
default:
|
|
f.addWhere("(movies." + *isMissing + " IS NULL OR TRIM(movies." + *isMissing + ") = '')")
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func movieStudioCriterionHandler(qb *movieQueryBuilder, studios *models.HierarchicalMultiCriterionInput) criterionHandlerFunc {
|
|
h := hierarchicalMultiCriterionHandlerBuilder{
|
|
tx: qb.tx,
|
|
|
|
primaryTable: movieTable,
|
|
foreignTable: studioTable,
|
|
foreignFK: studioIDColumn,
|
|
derivedTable: "studio",
|
|
parentFK: "parent_id",
|
|
}
|
|
|
|
return h.handler(studios)
|
|
}
|
|
|
|
func moviePerformersCriterionHandler(qb *movieQueryBuilder, performers *models.MultiCriterionInput) criterionHandlerFunc {
|
|
return func(f *filterBuilder) {
|
|
if performers != nil && len(performers.Value) > 0 {
|
|
var args []interface{}
|
|
for _, arg := range performers.Value {
|
|
args = append(args, arg)
|
|
}
|
|
|
|
// Hack, can't apply args to join, nor inner join on a left join, so use CTE instead
|
|
f.addWith(`movies_performers AS (
|
|
SELECT movies_scenes.movie_id, performers_scenes.performer_id
|
|
FROM movies_scenes
|
|
INNER JOIN performers_scenes ON movies_scenes.scene_id = performers_scenes.scene_id
|
|
WHERE performers_scenes.performer_id IN`+getInBinding(len(performers.Value))+`
|
|
)`, args...)
|
|
f.addJoin("movies_performers", "", "movies.id = movies_performers.movie_id")
|
|
|
|
switch performers.Modifier {
|
|
case models.CriterionModifierIncludes:
|
|
f.addWhere("movies_performers.performer_id IS NOT NULL")
|
|
case models.CriterionModifierIncludesAll:
|
|
f.addWhere("movies_performers.performer_id IS NOT NULL")
|
|
f.addHaving("COUNT(DISTINCT movies_performers.performer_id) = ?", len(performers.Value))
|
|
case models.CriterionModifierExcludes:
|
|
f.addWhere("movies_performers.performer_id IS NULL")
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) getMovieSort(findFilter *models.FindFilterType) string {
|
|
var sort string
|
|
var direction string
|
|
if findFilter == nil {
|
|
sort = "name"
|
|
direction = "ASC"
|
|
} else {
|
|
sort = findFilter.GetSort("name")
|
|
direction = findFilter.GetDirection()
|
|
}
|
|
|
|
switch sort {
|
|
case "name": // #943 - override name sorting to use natural sort
|
|
return " ORDER BY " + getColumn("movies", sort) + " COLLATE NATURAL_CS " + direction
|
|
case "scenes_count": // generic getSort won't work for this
|
|
return getCountSort(movieTable, moviesScenesTable, movieIDColumn, direction)
|
|
default:
|
|
return getSort(sort, direction, "movies")
|
|
}
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) queryMovie(query string, args []interface{}) (*models.Movie, error) {
|
|
results, err := qb.queryMovies(query, args)
|
|
if err != nil || len(results) < 1 {
|
|
return nil, err
|
|
}
|
|
return results[0], nil
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) queryMovies(query string, args []interface{}) ([]*models.Movie, error) {
|
|
var ret models.Movies
|
|
if err := qb.query(query, args, &ret); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return []*models.Movie(ret), nil
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) UpdateImages(movieID int, frontImage []byte, backImage []byte) error {
|
|
// Delete the existing cover and then create new
|
|
if err := qb.DestroyImages(movieID); err != nil {
|
|
return err
|
|
}
|
|
|
|
_, err := qb.tx.Exec(
|
|
`INSERT INTO movies_images (movie_id, front_image, back_image) VALUES (?, ?, ?)`,
|
|
movieID,
|
|
frontImage,
|
|
backImage,
|
|
)
|
|
|
|
return err
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) DestroyImages(movieID int) error {
|
|
// Delete the existing joins
|
|
_, err := qb.tx.Exec("DELETE FROM movies_images WHERE movie_id = ?", movieID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return err
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) GetFrontImage(movieID int) ([]byte, error) {
|
|
query := `SELECT front_image from movies_images WHERE movie_id = ?`
|
|
return getImage(qb.tx, query, movieID)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) GetBackImage(movieID int) ([]byte, error) {
|
|
query := `SELECT back_image from movies_images WHERE movie_id = ?`
|
|
return getImage(qb.tx, query, movieID)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) FindByPerformerID(performerID int) ([]*models.Movie, error) {
|
|
query := `SELECT DISTINCT movies.*
|
|
FROM movies
|
|
INNER JOIN movies_scenes ON movies.id = movies_scenes.movie_id
|
|
INNER JOIN performers_scenes ON performers_scenes.scene_id = movies_scenes.scene_id
|
|
WHERE performers_scenes.performer_id = ?
|
|
`
|
|
args := []interface{}{performerID}
|
|
return qb.queryMovies(query, args)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) CountByPerformerID(performerID int) (int, error) {
|
|
query := `SELECT COUNT(DISTINCT movies_scenes.movie_id) AS count
|
|
FROM movies_scenes
|
|
INNER JOIN performers_scenes ON performers_scenes.scene_id = movies_scenes.scene_id
|
|
WHERE performers_scenes.performer_id = ?
|
|
`
|
|
args := []interface{}{performerID}
|
|
return qb.runCountQuery(query, args)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) FindByStudioID(studioID int) ([]*models.Movie, error) {
|
|
query := `SELECT movies.*
|
|
FROM movies
|
|
WHERE movies.studio_id = ?
|
|
`
|
|
args := []interface{}{studioID}
|
|
return qb.queryMovies(query, args)
|
|
}
|
|
|
|
func (qb *movieQueryBuilder) CountByStudioID(studioID int) (int, error) {
|
|
query := `SELECT COUNT(1) AS count
|
|
FROM movies
|
|
WHERE movies.studio_id = ?
|
|
`
|
|
args := []interface{}{studioID}
|
|
return qb.runCountQuery(query, args)
|
|
}
|