mirror of
https://github.com/stashapp/stash.git
synced 2025-12-17 04:14:39 +03:00
* Make the script scraper context-aware Connect the context to the command execution. This means command execution can be aborted if the context is canceled. The context is usually bound to user-interaction, i.e., a scraper operation issued by the user. Hence, it seems correct to abort a command if the user aborts. * Enable errchkjson Some json marshal calls are *safe* in that they can never fail. This is conditional on the types of the the data being encoded. errchkjson finds those calls which are unsafe, and also not checked for errors. Add logging warnings to the place where unsafe encodings might happen. This can help uncover usage bugs early in stash if they are tripped, making debugging easier. While here, keep the checker enabled in the linter to capture future uses of json marshalling. * Pass the context for zip file scanning. * Pass the context in scanning * Pass context, replace context.TODO() Where applicable, pass the context down toward the lower functions in the call stack. Replace uses of context.TODO() with the passed context. This makes the code more context-aware, and you can rely on aborting contexts to clean up subsystems to a far greater extent now. I've left the cases where there is a context in a struct. My gut feeling is that they have solutions that are nice, but they require more deep thinking to unveil how to handle it. * Remove context from task-structs As a rule, contexts are better passed explicitly to functions than they are passed implicitly via structs. In the case of tasks, we already have a valid context in scope when creating the struct, so remove ctx from the struct and use the scoped context instead. With this change it is clear that the scanning functions are under a context, and the task-starting caller has jurisdiction over the context and its lifetime. A reader of the code don't have to figure out where the context are coming from anymore. While here, connect context.TODO() to the newly scoped context in most of the scan code. * Remove context from autotag struct too * Make more context-passing explicit In all of these cases, there is an applicable context which is close in the call-tree. Hook up to this context. * Simplify context passing in manager The managers context handling generally wants to use an outer context if applicable. However, the code doesn't pass it explicitly, but stores it in a struct. Pull out the context from the struct and use it to explicitly pass it. At a later point in time, we probably want to handle this by handing over the job to a different (program-lifetime) context for background jobs, but this will do for a start.
242 lines
7.0 KiB
Go
242 lines
7.0 KiB
Go
package manager
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"path/filepath"
|
|
"strconv"
|
|
|
|
"github.com/stashapp/stash/pkg/ffmpeg"
|
|
"github.com/stashapp/stash/pkg/fsutil"
|
|
"github.com/stashapp/stash/pkg/logger"
|
|
"github.com/stashapp/stash/pkg/models"
|
|
)
|
|
|
|
type GenerateMarkersTask struct {
|
|
TxnManager models.TransactionManager
|
|
Scene *models.Scene
|
|
Marker *models.SceneMarker
|
|
Overwrite bool
|
|
fileNamingAlgorithm models.HashAlgorithm
|
|
|
|
ImagePreview bool
|
|
Screenshot bool
|
|
}
|
|
|
|
func (t *GenerateMarkersTask) GetDescription() string {
|
|
if t.Scene != nil {
|
|
return fmt.Sprintf("Generating markers for %s", t.Scene.Path)
|
|
} else if t.Marker != nil {
|
|
return fmt.Sprintf("Generating marker preview for marker ID %d", t.Marker.ID)
|
|
}
|
|
|
|
return "Generating markers"
|
|
}
|
|
|
|
func (t *GenerateMarkersTask) Start(ctx context.Context) {
|
|
if t.Scene != nil {
|
|
t.generateSceneMarkers(ctx)
|
|
}
|
|
|
|
if t.Marker != nil {
|
|
var scene *models.Scene
|
|
if err := t.TxnManager.WithReadTxn(ctx, func(r models.ReaderRepository) error {
|
|
var err error
|
|
scene, err = r.Scene().Find(int(t.Marker.SceneID.Int64))
|
|
return err
|
|
}); err != nil {
|
|
logger.Errorf("error finding scene for marker: %s", err.Error())
|
|
return
|
|
}
|
|
|
|
if scene == nil {
|
|
logger.Errorf("scene not found for id %d", t.Marker.SceneID.Int64)
|
|
return
|
|
}
|
|
|
|
ffprobe := instance.FFProbe
|
|
videoFile, err := ffprobe.NewVideoFile(t.Scene.Path, false)
|
|
if err != nil {
|
|
logger.Errorf("error reading video file: %s", err.Error())
|
|
return
|
|
}
|
|
|
|
t.generateMarker(videoFile, scene, t.Marker)
|
|
}
|
|
}
|
|
|
|
func (t *GenerateMarkersTask) generateSceneMarkers(ctx context.Context) {
|
|
var sceneMarkers []*models.SceneMarker
|
|
if err := t.TxnManager.WithReadTxn(ctx, func(r models.ReaderRepository) error {
|
|
var err error
|
|
sceneMarkers, err = r.SceneMarker().FindBySceneID(t.Scene.ID)
|
|
return err
|
|
}); err != nil {
|
|
logger.Errorf("error getting scene markers: %s", err.Error())
|
|
return
|
|
}
|
|
|
|
if len(sceneMarkers) == 0 {
|
|
return
|
|
}
|
|
|
|
ffprobe := instance.FFProbe
|
|
videoFile, err := ffprobe.NewVideoFile(t.Scene.Path, false)
|
|
if err != nil {
|
|
logger.Errorf("error reading video file: %s", err.Error())
|
|
return
|
|
}
|
|
|
|
sceneHash := t.Scene.GetHash(t.fileNamingAlgorithm)
|
|
|
|
// Make the folder for the scenes markers
|
|
markersFolder := filepath.Join(instance.Paths.Generated.Markers, sceneHash)
|
|
if err := fsutil.EnsureDir(markersFolder); err != nil {
|
|
logger.Warnf("could not create the markers folder (%v): %v", markersFolder, err)
|
|
}
|
|
|
|
for i, sceneMarker := range sceneMarkers {
|
|
index := i + 1
|
|
logger.Progressf("[generator] <%s> scene marker %d of %d", sceneHash, index, len(sceneMarkers))
|
|
|
|
t.generateMarker(videoFile, t.Scene, sceneMarker)
|
|
}
|
|
}
|
|
|
|
func (t *GenerateMarkersTask) generateMarker(videoFile *ffmpeg.VideoFile, scene *models.Scene, sceneMarker *models.SceneMarker) {
|
|
sceneHash := t.Scene.GetHash(t.fileNamingAlgorithm)
|
|
seconds := int(sceneMarker.Seconds)
|
|
|
|
videoExists := t.videoExists(sceneHash, seconds)
|
|
imageExists := !t.ImagePreview || t.imageExists(sceneHash, seconds)
|
|
screenshotExists := !t.Screenshot || t.screenshotExists(sceneHash, seconds)
|
|
|
|
baseFilename := strconv.Itoa(seconds)
|
|
|
|
options := ffmpeg.SceneMarkerOptions{
|
|
ScenePath: scene.Path,
|
|
Seconds: seconds,
|
|
Width: 640,
|
|
Audio: instance.Config.GetPreviewAudio(),
|
|
}
|
|
|
|
encoder := instance.FFMPEG
|
|
|
|
if t.Overwrite || !videoExists {
|
|
videoFilename := baseFilename + ".mp4"
|
|
videoPath := instance.Paths.SceneMarkers.GetStreamPath(sceneHash, seconds)
|
|
|
|
options.OutputPath = instance.Paths.Generated.GetTmpPath(videoFilename) // tmp output in case the process ends abruptly
|
|
if err := encoder.SceneMarkerVideo(*videoFile, options); err != nil {
|
|
logger.Errorf("[generator] failed to generate marker video: %s", err)
|
|
} else {
|
|
_ = fsutil.SafeMove(options.OutputPath, videoPath)
|
|
logger.Debug("created marker video: ", videoPath)
|
|
}
|
|
}
|
|
|
|
if t.ImagePreview && (t.Overwrite || !imageExists) {
|
|
imageFilename := baseFilename + ".webp"
|
|
imagePath := instance.Paths.SceneMarkers.GetStreamPreviewImagePath(sceneHash, seconds)
|
|
|
|
options.OutputPath = instance.Paths.Generated.GetTmpPath(imageFilename) // tmp output in case the process ends abruptly
|
|
if err := encoder.SceneMarkerImage(*videoFile, options); err != nil {
|
|
logger.Errorf("[generator] failed to generate marker image: %s", err)
|
|
} else {
|
|
_ = fsutil.SafeMove(options.OutputPath, imagePath)
|
|
logger.Debug("created marker image: ", imagePath)
|
|
}
|
|
}
|
|
|
|
if t.Screenshot && (t.Overwrite || !screenshotExists) {
|
|
screenshotFilename := baseFilename + ".jpg"
|
|
screenshotPath := instance.Paths.SceneMarkers.GetStreamScreenshotPath(sceneHash, seconds)
|
|
|
|
screenshotOptions := ffmpeg.ScreenshotOptions{
|
|
OutputPath: instance.Paths.Generated.GetTmpPath(screenshotFilename), // tmp output in case the process ends abruptly
|
|
Quality: 2,
|
|
Width: videoFile.Width,
|
|
Time: float64(seconds),
|
|
}
|
|
if err := encoder.Screenshot(*videoFile, screenshotOptions); err != nil {
|
|
logger.Errorf("[generator] failed to generate marker screenshot: %s", err)
|
|
} else {
|
|
_ = fsutil.SafeMove(screenshotOptions.OutputPath, screenshotPath)
|
|
logger.Debug("created marker screenshot: ", screenshotPath)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (t *GenerateMarkersTask) markersNeeded(ctx context.Context) int {
|
|
markers := 0
|
|
var sceneMarkers []*models.SceneMarker
|
|
if err := t.TxnManager.WithReadTxn(ctx, func(r models.ReaderRepository) error {
|
|
var err error
|
|
sceneMarkers, err = r.SceneMarker().FindBySceneID(t.Scene.ID)
|
|
return err
|
|
}); err != nil {
|
|
logger.Errorf("errror finding scene markers: %s", err.Error())
|
|
return 0
|
|
}
|
|
|
|
if len(sceneMarkers) == 0 {
|
|
return 0
|
|
}
|
|
|
|
sceneHash := t.Scene.GetHash(t.fileNamingAlgorithm)
|
|
for _, sceneMarker := range sceneMarkers {
|
|
seconds := int(sceneMarker.Seconds)
|
|
|
|
if t.Overwrite || !t.markerExists(sceneHash, seconds) {
|
|
markers++
|
|
}
|
|
}
|
|
|
|
return markers
|
|
}
|
|
|
|
func (t *GenerateMarkersTask) markerExists(sceneChecksum string, seconds int) bool {
|
|
if sceneChecksum == "" {
|
|
return false
|
|
}
|
|
|
|
videoExists := t.videoExists(sceneChecksum, seconds)
|
|
imageExists := !t.ImagePreview || t.imageExists(sceneChecksum, seconds)
|
|
screenshotExists := !t.Screenshot || t.screenshotExists(sceneChecksum, seconds)
|
|
|
|
return videoExists && imageExists && screenshotExists
|
|
}
|
|
|
|
func (t *GenerateMarkersTask) videoExists(sceneChecksum string, seconds int) bool {
|
|
if sceneChecksum == "" {
|
|
return false
|
|
}
|
|
|
|
videoPath := instance.Paths.SceneMarkers.GetStreamPath(sceneChecksum, seconds)
|
|
videoExists, _ := fsutil.FileExists(videoPath)
|
|
|
|
return videoExists
|
|
}
|
|
|
|
func (t *GenerateMarkersTask) imageExists(sceneChecksum string, seconds int) bool {
|
|
if sceneChecksum == "" {
|
|
return false
|
|
}
|
|
|
|
imagePath := instance.Paths.SceneMarkers.GetStreamPreviewImagePath(sceneChecksum, seconds)
|
|
imageExists, _ := fsutil.FileExists(imagePath)
|
|
|
|
return imageExists
|
|
}
|
|
|
|
func (t *GenerateMarkersTask) screenshotExists(sceneChecksum string, seconds int) bool {
|
|
if sceneChecksum == "" {
|
|
return false
|
|
}
|
|
|
|
screenshotPath := instance.Paths.SceneMarkers.GetStreamScreenshotPath(sceneChecksum, seconds)
|
|
screenshotExists, _ := fsutil.FileExists(screenshotPath)
|
|
|
|
return screenshotExists
|
|
}
|