Toast fixes/refactoring (#4289)

* Memoize Toast functions
* Rename Toast.success to Toast.toast, add new Toast.success
* Disable prefer-destructuring on AssignmentExpression
This commit is contained in:
DingDongSoLong4
2023-11-20 05:14:34 +02:00
committed by GitHub
parent 049a1b15c3
commit f9e11813f0
52 changed files with 336 additions and 387 deletions

View File

@@ -82,16 +82,16 @@ export const SavedFilterList: React.FC<ISavedFilterListProps> = ({
},
});
Toast.success({
content: intl.formatMessage(
Toast.success(
intl.formatMessage(
{
id: "toast.saved_entity",
},
{
entity: intl.formatMessage({ id: "filter" }).toLocaleLowerCase(),
}
),
});
)
);
setFilterName("");
setOverwritingFilter(undefined);
refetch();
@@ -114,8 +114,8 @@ export const SavedFilterList: React.FC<ISavedFilterListProps> = ({
},
});
Toast.success({
content: intl.formatMessage(
Toast.success(
intl.formatMessage(
{
id: "toast.delete_past_tense",
},
@@ -124,8 +124,8 @@ export const SavedFilterList: React.FC<ISavedFilterListProps> = ({
singularEntity: intl.formatMessage({ id: "filter" }),
pluralEntity: intl.formatMessage({ id: "filters" }),
}
),
});
)
);
refetch();
} catch (err) {
Toast.error(err);
@@ -152,11 +152,11 @@ export const SavedFilterList: React.FC<ISavedFilterListProps> = ({
},
});
Toast.success({
content: intl.formatMessage({
Toast.success(
intl.formatMessage({
id: "toast.default_filter_set",
}),
});
})
);
} catch (err) {
Toast.error(err);
} finally {