From ed9f35a973fd02a13cb51bd7384e80daa81a43b1 Mon Sep 17 00:00:00 2001 From: WithoutPants <53250216+WithoutPants@users.noreply.github.com> Date: Tue, 8 Aug 2023 11:00:20 +1000 Subject: [PATCH] Fix create missing checkbox not persisting (#4008) --- .../Dialogs/IdentifyDialog/FieldOptions.tsx | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/ui/v2.5/src/components/Dialogs/IdentifyDialog/FieldOptions.tsx b/ui/v2.5/src/components/Dialogs/IdentifyDialog/FieldOptions.tsx index 79fe2b6c1..8ab84b5de 100644 --- a/ui/v2.5/src/components/Dialogs/IdentifyDialog/FieldOptions.tsx +++ b/ui/v2.5/src/components/Dialogs/IdentifyDialog/FieldOptions.tsx @@ -190,19 +190,24 @@ const FieldOptionsEditor: React.FC = ({ return; } + const localOptionsCopy = { ...localOptions }; + if (localOptionsCopy.strategy === undefined && !allowSetDefault) { + localOptionsCopy.strategy = GQL.IdentifyFieldStrategy.Merge; + } + // send null if strategy is undefined - if (localOptions.strategy === undefined) { + if (localOptionsCopy.strategy === undefined) { editOptions(null); resetOptions(); } else { - let { createMissing } = localOptions; + let { createMissing } = localOptionsCopy; if (createMissing === undefined && !allowSetDefault) { createMissing = false; } editOptions({ - ...localOptions, - strategy: localOptions.strategy, + ...localOptionsCopy, + strategy: localOptionsCopy.strategy, createMissing, }); }