Add detection of container/video_codec/audio_codec compatibility for live file streaming or transcoding (#384)

* add forceMKV, forceHEVC config options
* drop audio stream instead of trying to transcode for ffmpeg unsupported/unknown audio codecs

pkg/ffmpeg/ffprobe.go

@@ -10,11 +10,105 @@ import (
 	"strconv"
 	"strings"
 	"time"
+
+	"github.com/stashapp/stash/pkg/manager/config"
 )
 
-var ValidCodecs = []string{"h264", "h265", "vp8", "vp9"}
+type Container string
+type AudioCodec string
+
+const (
+	Mp4                Container  = "mp4"
+	M4v                Container  = "m4v"
+	Mov                Container  = "mov"
+	Wmv                Container  = "wmv"
+	Webm               Container  = "webm"
+	Matroska           Container  = "matroska"
+	Avi                Container  = "avi"
+	Flv                Container  = "flv"
+	Mpegts             Container  = "mpegts"
+	Aac                AudioCodec = "aac"
+	Mp3                AudioCodec = "mp3"
+	Opus               AudioCodec = "opus"
+	Vorbis             AudioCodec = "vorbis"
+	MissingUnsupported AudioCodec = ""
+	Mp4Ffmpeg          string     = "mov,mp4,m4a,3gp,3g2,mj2" // browsers support all of them
+	M4vFfmpeg          string     = "mov,mp4,m4a,3gp,3g2,mj2" // so we don't care that ffmpeg
+	MovFfmpeg          string     = "mov,mp4,m4a,3gp,3g2,mj2" // can't differentiate between them
+	WmvFfmpeg          string     = "asf"
+	WebmFfmpeg         string     = "matroska,webm"
+	MatroskaFfmpeg     string     = "matroska,webm"
+	AviFfmpeg          string     = "avi"
+	FlvFfmpeg          string     = "flv"
+	MpegtsFfmpeg       string     = "mpegts"
+	H264               string     = "h264"
+	H265               string     = "h265" // found in rare cases from a faulty encoder
+	Hevc               string     = "hevc"
+	Vp8                string     = "vp8"
+	Vp9                string     = "vp9"
+	MimeWebm           string     = "video/webm"
+	MimeMkv            string     = "video/x-matroska"
+)
+
+var ValidCodecs = []string{H264, H265, Vp8, Vp9}
+
+var validForH264Mkv = []Container{Mp4, Matroska}
+var validForH264 = []Container{Mp4}
+var validForH265Mkv = []Container{Mp4, Matroska}
+var validForH265 = []Container{Mp4}
+var validForVp8 = []Container{Webm}
+var validForVp9Mkv = []Container{Webm, Matroska}
+var validForVp9 = []Container{Webm}
+var validForHevcMkv = []Container{Mp4, Matroska}
+var validForHevc = []Container{Mp4}
+
+var validAudioForMkv = []AudioCodec{Aac, Mp3, Vorbis, Opus}
+var validAudioForWebm = []AudioCodec{Vorbis, Opus}
+var validAudioForMp4 = []AudioCodec{Aac, Mp3}
+
+//maps user readable container strings to ffprobe's format_name
+//on some formats ffprobe can't differentiate
+var ContainerToFfprobe = map[Container]string{
+	Mp4:      Mp4Ffmpeg,
+	M4v:      M4vFfmpeg,
+	Mov:      MovFfmpeg,
+	Wmv:      WmvFfmpeg,
+	Webm:     WebmFfmpeg,
+	Matroska: MatroskaFfmpeg,
+	Avi:      AviFfmpeg,
+	Flv:      FlvFfmpeg,
+	Mpegts:   MpegtsFfmpeg,
+}
+
+var FfprobeToContainer = map[string]Container{
+	Mp4Ffmpeg:      Mp4,
+	WmvFfmpeg:      Wmv,
+	AviFfmpeg:      Avi,
+	FlvFfmpeg:      Flv,
+	MpegtsFfmpeg:   Mpegts,
+	MatroskaFfmpeg: Matroska,
+}
+
+func MatchContainer(format string, filePath string) Container { // match ffprobe string to our Container
+
+	container := FfprobeToContainer[format]
+	if container == Matroska {
+		container = MagicContainer(filePath) // use magic number instead of ffprobe for matroska,webm
+	}
+	if container == "" { // if format is not in our Container list leave it as ffprobes reported format_name
+		container = Container(format)
+	}
+	return container
+}
 
 func IsValidCodec(codecName string) bool {
+	forceHEVC := config.GetForceHEVC()
+	if forceHEVC {
+		if codecName == Hevc {
+			return true
+		}
+	}
+
 	for _, c := range ValidCodecs {
 		if c == codecName {
 			return true
@@ -23,6 +117,78 @@ func IsValidCodec(codecName string) bool {
 	return false
 }
 
+func IsValidAudio(audio AudioCodec, ValidCodecs []AudioCodec) bool {
+
+	// if audio codec is missing or unsupported by ffmpeg we can't do anything about it
+	// report it as valid so that the file can at least be streamed directly if the video codec is supported
+	if audio == MissingUnsupported {
+		return true
+	}
+
+	for _, c := range ValidCodecs {
+		if c == audio {
+			return true
+		}
+	}
+
+	return false
+}
+
+func IsValidAudioForContainer(audio AudioCodec, format Container) bool {
+	switch format {
+	case Matroska:
+		return IsValidAudio(audio, validAudioForMkv)
+	case Webm:
+		return IsValidAudio(audio, validAudioForWebm)
+	case Mp4:
+		return IsValidAudio(audio, validAudioForMp4)
+	}
+	return false
+
+}
+
+func IsValidForContainer(format Container, validContainers []Container) bool {
+	for _, fmt := range validContainers {
+		if fmt == format {
+			return true
+		}
+	}
+	return false
+}
+
+//extend stream validation check to take into account container
+func IsValidCombo(codecName string, format Container) bool {
+	forceMKV := config.GetForceMKV()
+	forceHEVC := config.GetForceHEVC()
+	switch codecName {
+	case H264:
+		if forceMKV {
+			return IsValidForContainer(format, validForH264Mkv)
+		}
+		return IsValidForContainer(format, validForH264)
+	case H265:
+		if forceMKV {
+			return IsValidForContainer(format, validForH265Mkv)
+		}
+		return IsValidForContainer(format, validForH265)
+	case Vp8:
+		return IsValidForContainer(format, validForVp8)
+	case Vp9:
+		if forceMKV {
+			return IsValidForContainer(format, validForVp9Mkv)
+		}
+		return IsValidForContainer(format, validForVp9)
+	case Hevc:
+		if forceHEVC {
+			if forceMKV {
+				return IsValidForContainer(format, validForHevcMkv)
+			}
+			return IsValidForContainer(format, validForHevc)
+		}
+	}
+	return false
+}
+
 type VideoFile struct {
 	JSON        FFProbeJSON
 	AudioStream *FFProbeStream