From d2a0a8fe4c743250156e5bc7f6fc2ab5eaf8ad72 Mon Sep 17 00:00:00 2001
From: SmallCoccinelle <89733524+SmallCoccinelle@users.noreply.github.com>
Date: Wed, 8 Sep 2021 03:22:56 +0200
Subject: [PATCH] Correct error propagation (#1703)

Rename an inner error to imageErr. This avoids a shadowing of an error
in the following lines which aren't returned otherwise.
---
 pkg/manager/task_stash_box_tag.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pkg/manager/task_stash_box_tag.go b/pkg/manager/task_stash_box_tag.go
index 5bd5c2252..edbcd83e4 100644
--- a/pkg/manager/task_stash_box_tag.go
+++ b/pkg/manager/task_stash_box_tag.go
@@ -229,9 +229,9 @@ func (t *StashBoxPerformerTagTask) stashBoxPerformerTag() {
 				}
 
 				if len(performer.Images) > 0 {
-					image, err := utils.ReadImageFromURL(performer.Images[0])
-					if err != nil {
-						return err
+					image, imageErr := utils.ReadImageFromURL(performer.Images[0])
+					if imageErr != nil {
+						return imageErr
 					}
 					err = r.Performer().UpdateImage(createdPerformer.ID, image)
 				}