From cc5ec650ae7154beec459bd2ea482f6f3ff56340 Mon Sep 17 00:00:00 2001 From: peolic <66393006+peolic@users.noreply.github.com> Date: Wed, 26 May 2021 00:29:51 +0300 Subject: [PATCH] Fix scraper date parser failing when parsing time (#1431) * Don't mutate the original scraped date `time.Parse` is case-sensitive for some values, `AM/pm` in particular --- pkg/scraper/mapped.go | 6 +++--- ui/v2.5/src/components/Changelog/versions/v080.md | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/pkg/scraper/mapped.go b/pkg/scraper/mapped.go index d6341c396..5cbdead74 100644 --- a/pkg/scraper/mapped.go +++ b/pkg/scraper/mapped.go @@ -368,10 +368,10 @@ func (p *postProcessParseDate) Apply(value string, q mappedQuery) string { const internalDateFormat = "2006-01-02" - value = strings.ToLower(value) - if value == "today" || value == "yesterday" { // handle today, yesterday + valueLower := strings.ToLower(value) + if valueLower == "today" || valueLower == "yesterday" { // handle today, yesterday dt := time.Now() - if value == "yesterday" { // subtract 1 day from now + if valueLower == "yesterday" { // subtract 1 day from now dt = dt.AddDate(0, 0, -1) } return dt.Format(internalDateFormat) diff --git a/ui/v2.5/src/components/Changelog/versions/v080.md b/ui/v2.5/src/components/Changelog/versions/v080.md index 82b5ff5e4..82b7d65ab 100644 --- a/ui/v2.5/src/components/Changelog/versions/v080.md +++ b/ui/v2.5/src/components/Changelog/versions/v080.md @@ -12,5 +12,6 @@ * Add button to remove studio stash ID. ([#1378](https://github.com/stashapp/stash/pull/1378)) ### 🐛 Bug fixes +* Fix scraper date parser failing when parsing time. ([#1431](https://github.com/stashapp/stash/pull/1431)) * Fix quotes in filter labels causing UI errors. ([#1425](https://github.com/stashapp/stash/pull/1425)) * Fix post-processing not running when scraping by performer fragment. ([#1387](https://github.com/stashapp/stash/pull/1387))