Mirrors/stash
1
0
Fork 0
mirror of https://github.com/stashapp/stash.git synced 2025-12-17 12:24:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix performer migration (#3285)

Browse Source 
* Recreate performers table instead of drop column
* Use performer_aliases to store original value
This commit is contained in:
WithoutPants
2022-12-19 11:24:42 +11:00
committed by GitHub
parent 150c496949
commit cc4b0f7b11
2 changed files with 121 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/sqlite/migrations/42_postmigrate.go
View File

@@ -56,13 +56,13 @@ func (m *schema42Migrator) migrate(ctx context.Context) error {
gotSome := false
if err := m.withTxn(ctx, func(tx *sqlx.Tx) error {
query := "SELECT `id`, `aliases` FROM `performers` WHERE `aliases` IS NOT NULL AND `aliases` != ''"
query := "SELECT `performer_id`, `alias` FROM `performer_aliases`"
if lastID != 0 {
query += fmt.Sprintf(" AND `id` > %d ", lastID)
query += fmt.Sprintf(" WHERE `performer_id` > %d ", lastID)
}
query += fmt.Sprintf(" ORDER BY `id` LIMIT %d", limit)
query += fmt.Sprintf(" ORDER BY `performer_id` LIMIT %d", limit)
rows, err := m.db.Query(query)
if err != nil {
@@ -113,6 +113,16 @@ func (m *schema42Migrator) migratePerformerAliases(id int, aliases string) error
return strings.ContainsRune(",/", r)
})
if len(aliasList) < 2 {
// existing value is fine
return nil
}
// delete the existing row
if _, err := m.db.Exec("DELETE FROM `performer_aliases` WHERE `performer_id` = ?", id); err != nil {
return err
}
// trim whitespace from each alias
for i, alias := range aliasList {
aliasList[i] = strings.TrimSpace(alias)
@@ -232,7 +242,6 @@ SELECT disambiguation FROM performers WHERE name = ? ORDER BY disambiguation DES
func (m *schema42Migrator) executeSchemaChanges() error {
return m.execAll([]string{
"ALTER TABLE `performers` DROP COLUMN `aliases`",
"CREATE UNIQUE INDEX `performers_name_disambiguation_unique` on `performers` (`name`, `disambiguation`) WHERE `disambiguation` IS NOT NULL",
"CREATE UNIQUE INDEX `performers_name_unique` on `performers` (`name`) WHERE `disambiguation` IS NULL",
})