Overwrite phash during generate if flag set (#1633)

pkg/manager/manager_tasks.go

@@ -322,6 +322,7 @@ func (s *singleton) Generate(ctx context.Context, input models.GenerateMetadataI
 					Scene:               *scene,
 					fileNamingAlgorithm: fileNamingAlgo,
 					txnManager:          s.TxnManager,
+					Overwrite:           overwrite,
 				}
 				wg.Add()
 				go progress.ExecuteTask(fmt.Sprintf("Generating phash for %s", scene.Path), func() {

pkg/manager/task_generate_phash.go

@@ -13,6 +13,7 @@ import (
 
 type GeneratePhashTask struct {
 	Scene               models.Scene
+	Overwrite           bool
 	fileNamingAlgorithm models.HashAlgorithm
 	txnManager          models.TransactionManager
 }
@@ -58,5 +59,5 @@ func (t *GeneratePhashTask) Start(wg *sizedwaitgroup.SizedWaitGroup) {
 }
 
 func (t *GeneratePhashTask) shouldGenerate() bool {
-	return !t.Scene.Phash.Valid
+	return t.Overwrite || !t.Scene.Phash.Valid
 }

ui/v2.5/src/components/Changelog/versions/v090.md

@@ -16,6 +16,7 @@
 * Added de-DE language option. ([#1578](https://github.com/stashapp/stash/pull/1578))
 
 ### 🐛 Bug fixes
+* Regenerate scene phash if overwrite flag is set. ([#1633](https://github.com/stashapp/stash/pull/1633))
 * Create .stash directory in $HOME only if required. ([#1623](https://github.com/stashapp/stash/pull/1623))
 * Include stash id when scraping performer from stash-box. ([#1608](https://github.com/stashapp/stash/pull/1608))
 * Fix infinity framerate values causing resolver error. ([#1607](https://github.com/stashapp/stash/pull/1607))