Containing Group/Sub-Group relationships (#5105)

* Add UI support for setting containing groups
* Show containing groups in group details panel
* Move tag hierarchical filter code into separate type
* Add depth to scene_count and add sub_group_count
* Add sub-groups tab to groups page
* Add containing groups to edit groups dialog
* Show containing group description in sub-group view
* Show group scene number in group scenes view
* Add ability to drag move grid cards
* Add sub group order option
* Add reorder sub-groups interface
* Separate page size selector component
* Add interfaces to add and remove sub-groups to a group
* Separate MultiSet components
* Allow setting description while setting containing groups

pkg/group/validate.go

@@ -0,0 +1,117 @@
+package group
+
+import (
+	"context"
+	"strings"
+
+	"github.com/stashapp/stash/pkg/models"
+	"github.com/stashapp/stash/pkg/sliceutil"
+)
+
+func (s *Service) validateCreate(ctx context.Context, group *models.Group) error {
+	if err := validateName(group.Name); err != nil {
+		return err
+	}
+
+	containingIDs := group.ContainingGroups.IDs()
+	subIDs := group.SubGroups.IDs()
+
+	if err := s.validateGroupHierarchy(ctx, containingIDs, subIDs); err != nil {
+		return err
+	}
+
+	return nil
+}
+
+func (s *Service) validateUpdate(ctx context.Context, id int, partial models.GroupPartial) error {
+	// get the existing group - ensure it exists
+	existing, err := s.Repository.Find(ctx, id)
+	if err != nil {
+		return err
+	}
+
+	if existing == nil {
+		return models.ErrNotFound
+	}
+
+	if partial.Name.Set {
+		if err := validateName(partial.Name.Value); err != nil {
+			return err
+		}
+	}
+
+	if err := s.validateUpdateGroupHierarchy(ctx, existing, partial.ContainingGroups, partial.SubGroups); err != nil {
+		return err
+	}
+
+	return nil
+}
+
+func validateName(n string) error {
+	// ensure name is not empty
+	if strings.TrimSpace(n) == "" {
+		return ErrEmptyName
+	}
+
+	return nil
+}
+
+func (s *Service) validateGroupHierarchy(ctx context.Context, containingIDs []int, subIDs []int) error {
+	// only need to validate if both are non-empty
+	if len(containingIDs) == 0 || len(subIDs) == 0 {
+		return nil
+	}
+
+	// ensure none of the containing groups are in the sub groups
+	found, err := s.Repository.FindInAncestors(ctx, containingIDs, subIDs)
+	if err != nil {
+		return err
+	}
+
+	if len(found) > 0 {
+		return ErrHierarchyLoop
+	}
+
+	return nil
+}
+
+func (s *Service) validateUpdateGroupHierarchy(ctx context.Context, existing *models.Group, containingGroups *models.UpdateGroupDescriptions, subGroups *models.UpdateGroupDescriptions) error {
+	// no need to validate if there are no changes
+	if containingGroups == nil && subGroups == nil {
+		return nil
+	}
+
+	if err := existing.LoadContainingGroupIDs(ctx, s.Repository); err != nil {
+		return err
+	}
+	existingContainingGroups := existing.ContainingGroups.List()
+
+	if err := existing.LoadSubGroupIDs(ctx, s.Repository); err != nil {
+		return err
+	}
+	existingSubGroups := existing.SubGroups.List()
+
+	effectiveContainingGroups := existingContainingGroups
+	if containingGroups != nil {
+		effectiveContainingGroups = containingGroups.Apply(existingContainingGroups)
+	}
+
+	effectiveSubGroups := existingSubGroups
+	if subGroups != nil {
+		effectiveSubGroups = subGroups.Apply(existingSubGroups)
+	}
+
+	containingIDs := idsFromGroupDescriptions(effectiveContainingGroups)
+	subIDs := idsFromGroupDescriptions(effectiveSubGroups)
+
+	// ensure we haven't set the group as a subgroup of itself
+	if sliceutil.Contains(containingIDs, existing.ID) || sliceutil.Contains(subIDs, existing.ID) {
+		return ErrHierarchyLoop
+	}
+
+	return s.validateGroupHierarchy(ctx, containingIDs, subIDs)
+}
+
+func idsFromGroupDescriptions(v []models.GroupIDDescription) []int {
+	return sliceutil.Map(v, func(g models.GroupIDDescription) int { return g.GroupID })
+}