Remove new-from-rev from the linter (#1783)

* Fix all revive warnings in the code base

All of these are of the form

```
var Identifier Type = Expr
```

where the `Type` is known from the output of `Expr` and can be omitted
as a result.

* Handle unchecked errors

* Remove new-from-rev

Since the project passes all linter checks now, including older
revisions, we can remove new-from-rev. While here, reorder the linter
config file, and move the enabled linters up and settings down.

* Fix failing test cases

Studio & Performer export tests use local time rather than UTC. This
fixes the test cases so integration test
passes.
This commit is contained in:
SmallCoccinelle
2021-09-28 01:29:45 +02:00
committed by GitHub
parent b94eecae24
commit bc6d04dc2a
12 changed files with 65 additions and 45 deletions

View File

@@ -39,8 +39,10 @@ const (
errChecksum = "errChecksum"
)
var createdAt time.Time = time.Date(2001, time.January, 2, 1, 2, 3, 4, time.Local)
var updatedAt time.Time = time.Date(2002, time.January, 2, 1, 2, 3, 4, time.Local)
var (
createdAt = time.Date(2001, time.January, 2, 1, 2, 3, 4, time.Local)
updatedAt = time.Date(2002, time.January, 2, 1, 2, 3, 4, time.Local)
)
func TestImporterName(t *testing.T) {
i := Importer{