Restructure ffmpeg (#2392)

* Refactor transcode generation
* Move phash generation into separate package
* Refactor image thumbnail generation
* Move JSONTime to separate package
* Ffmpeg refactoring
* Refactor live transcoding
* Refactor scene marker preview generation
* Refactor preview generation
* Refactor screenshot generation
* Refactor sprite generation
* Change ffmpeg.IsStreamable to return error
* Move frame rate calculation into ffmpeg
* Refactor file locking
* Refactor title set during scan
* Add missing lockmanager instance
* Return error instead of logging in MatchContainer

internal/manager/task_generate_screenshot.go

@@ -10,6 +10,7 @@ import (
 	"github.com/stashapp/stash/pkg/logger"
 	"github.com/stashapp/stash/pkg/models"
 	"github.com/stashapp/stash/pkg/scene"
+	"github.com/stashapp/stash/pkg/scene/generate"
 )
 
 type GenerateScreenshotTask struct {
@@ -22,7 +23,7 @@ type GenerateScreenshotTask struct {
 func (t *GenerateScreenshotTask) Start(ctx context.Context) {
 	scenePath := t.Scene.Path
 	ffprobe := instance.FFProbe
-	probeResult, err := ffprobe.NewVideoFile(scenePath, false)
+	probeResult, err := ffprobe.NewVideoFile(scenePath)
 
 	if err != nil {
 		logger.Error(err.Error())
@@ -44,7 +45,21 @@ func (t *GenerateScreenshotTask) Start(ctx context.Context) {
 	// which also generates the thumbnail
 
 	logger.Debugf("Creating screenshot for %s", scenePath)
-	makeScreenshot(*probeResult, normalPath, 2, probeResult.Width, at)
+
+	g := generate.Generator{
+		Encoder:     instance.FFMPEG,
+		LockManager: instance.ReadLockManager,
+		ScenePaths:  instance.Paths.Scene,
+		Overwrite:   true,
+	}
+
+	if err := g.Screenshot(context.TODO(), probeResult.Path, checksum, probeResult.Width, probeResult.Duration, generate.ScreenshotOptions{
+		At: &at,
+	}); err != nil {
+		logger.Errorf("Error generating screenshot: %v", err)
+		logErrorOutput(err)
+		return
+	}
 
 	f, err := os.Open(normalPath)
 	if err != nil {