Refactor file deletion (#1954)

* Add file deleter
* Change scene delete code
* Add image/gallery delete code
* Don't remove stash library paths
* Fail silently if file does not exist

pkg/image/delete.go

@@ -0,0 +1,48 @@
+package image
+
+import (
+	"github.com/stashapp/stash/pkg/file"
+	"github.com/stashapp/stash/pkg/manager/paths"
+	"github.com/stashapp/stash/pkg/models"
+	"github.com/stashapp/stash/pkg/utils"
+)
+
+type Destroyer interface {
+	Destroy(id int) error
+}
+
+// FileDeleter is an extension of file.Deleter that handles deletion of image files.
+type FileDeleter struct {
+	file.Deleter
+
+	Paths *paths.Paths
+}
+
+// MarkGeneratedFiles marks for deletion the generated files for the provided image.
+func (d *FileDeleter) MarkGeneratedFiles(image *models.Image) error {
+	thumbPath := d.Paths.Generated.GetThumbnailPath(image.Checksum, models.DefaultGthumbWidth)
+	exists, _ := utils.FileExists(thumbPath)
+	if exists {
+		return d.Files([]string{thumbPath})
+	}
+
+	return nil
+}
+
+// Destroy destroys an image, optionally marking the file and generated files for deletion.
+func Destroy(i *models.Image, destroyer Destroyer, fileDeleter *FileDeleter, deleteGenerated, deleteFile bool) error {
+	// don't try to delete if the image is in a zip file
+	if deleteFile && !file.IsZipPath(i.Path) {
+		if err := fileDeleter.Files([]string{i.Path}); err != nil {
+			return err
+		}
+	}
+
+	if deleteGenerated {
+		if err := fileDeleter.MarkGeneratedFiles(i); err != nil {
+			return err
+		}
+	}
+
+	return destroyer.Destroy(i.ID)
+}