[Files Refactor] Performance tuning (#2813)

* Do database txn in same thread. Retry on locked db
* Remove captions from slimscenedata
* Fix tracing
* Use where in instead of individual selects
* Remove scenes_query view
* Remove image query view
* Remove gallery query view
* Use where in for FindMany
* Don't interrupt scanning zip files
* Fix image filesize sort

pkg/sqlite/setup_test.go

@@ -458,10 +458,6 @@ var (
 )
 
 func indexesToIDs(ids []int, indexes []int) []int {
-	if len(indexes) == 0 {
-		return nil
-	}
-
 	ret := make([]int, len(indexes))
 	for i, idx := range indexes {
 		ret[i] = ids[idx]
@@ -964,13 +960,10 @@ func makeScene(i int) *models.Scene {
 
 	mids := indexesToIDs(movieIDs, sceneMovies[i])
 
-	var movies []models.MoviesScenes
-	if len(mids) > 0 {
-		movies = make([]models.MoviesScenes, len(mids))
-		for i, m := range mids {
-			movies[i] = models.MoviesScenes{
-				MovieID: m,
-			}
+	movies := make([]models.MoviesScenes, len(mids))
+	for i, m := range mids {
+		movies[i] = models.MoviesScenes{
+			MovieID: m,
 		}
 	}