Mirrors/stash
1
0
Fork 0
mirror of https://github.com/stashapp/stash.git synced 2025-12-17 04:14:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

Avoid wrapping strings.Replace in Contains (#1710)

Browse Source 
The strings.Replace function counts the number of replacements. If 0,
the original string is returned. Hence, there is no need to check if a
replacement will happen before doing the work.
This commit is contained in:
SmallCoccinelle
2021-09-09 06:10:39 +02:00
committed by GitHub
parent 4b00d24248
commit 82a41e17c7
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/scraper/mapped.go
View File

@@ -32,9 +32,7 @@ func (s mappedConfig) applyCommon(c commonMappedConfig, src string) string {
ret := src ret := src
for commonKey, commonVal := range c { for commonKey, commonVal := range c {
if strings.Contains(ret, commonKey) { ret = strings.Replace(ret, commonKey, commonVal, -1)
ret = strings.Replace(ret, commonKey, commonVal, -1)
}
} }
return ret return ret