Fix save disabled when creating new object with name (#3409)

* Dirty when creating with name
* Fix prompt on tag save

ui/v2.5/src/components/Galleries/GalleryDetails/GalleryEditPanel.tsx

@@ -120,6 +120,11 @@ export const GalleryEditPanel: React.FC<
     onSubmit: (values) => onSave(getGalleryInput(values)),
   });
 
+  // always dirty if creating a new gallery with a title
+  if (isNew && gallery?.title) {
+    formik.dirty = true;
+  }
+
   function setRating(v: number) {
     formik.setFieldValue("rating100", v);
   }

ui/v2.5/src/components/Performers/PerformerDetails/PerformerEditPanel.tsx

@@ -173,6 +173,11 @@ export const PerformerEditPanel: React.FC<IPerformerDetails> = ({
     onSubmit: (values) => onSave(values),
   });
 
+  // always dirty if creating a new performer with a name
+  if (isNew && performer.name) {
+    formik.dirty = true;
+  }
+
   function translateScrapedGender(scrapedGender?: string) {
     if (!scrapedGender) {
       return;

ui/v2.5/src/components/Studios/StudioDetails/StudioEditPanel.tsx

@@ -83,6 +83,11 @@ export const StudioEditPanel: React.FC<IStudioEditPanel> = ({
     onSubmit: (values) => onSubmit(getStudioInput(values)),
   });
 
+  // always dirty if creating a new studio with a name
+  if (isNew && studio.name) {
+    formik.dirty = true;
+  }
+
   function setRating(v: number) {
     formik.setFieldValue("rating100", v);
   }

ui/v2.5/src/components/Tags/TagDetails/TagCreate.tsx

@@ -62,7 +62,7 @@ const TagCreate: React.FC = () => {
           parents: created.parents,
           children: created.children,
         });
-        return created.id;
+        history.push(`/tags/${result.data.tagCreate.id}`);
       }
     } catch (e) {
       Toast.error(e);

ui/v2.5/src/components/Tags/TagDetails/TagEditPanel.tsx

@@ -6,16 +6,14 @@ import { DetailsEditNavbar, TagSelect } from "src/components/Shared";
 import { Form, Col, Row } from "react-bootstrap";
 import { FormUtils, ImageUtils } from "src/utils";
 import { useFormik } from "formik";
-import { Prompt, useHistory, useParams } from "react-router-dom";
+import { Prompt, useParams } from "react-router-dom";
 import Mousetrap from "mousetrap";
 import { StringListInput } from "src/components/Shared/StringListInput";
 
 interface ITagEditPanel {
   tag?: Partial<GQL.TagDataFragment>;
   // returns id
-  onSubmit: (
+  onSubmit: (tag: Partial<GQL.TagCreateInput | GQL.TagUpdateInput>) => void;
-    tag: Partial<GQL.TagCreateInput | GQL.TagUpdateInput>
-  ) => Promise<string | undefined>;
   onCancel: () => void;
   onDelete: () => void;
   setImage: (image?: string | null) => void;
@@ -33,7 +31,6 @@ export const TagEditPanel: React.FC<ITagEditPanel> = ({
   setImage,
 }) => {
   const intl = useIntl();
-  const history = useHistory();
 
   const params = useParams<ITagEditPanelParams>();
   const idParam = params.id;
@@ -79,15 +76,12 @@ export const TagEditPanel: React.FC<ITagEditPanel> = ({
     initialValues,
     validationSchema: schema,
     enableReinitialize: true,
-    onSubmit: doSubmit,
+    onSubmit: (values) => onSubmit(getTagInput(values)),
   });
 
-  async function doSubmit(values: InputValues) {
+  // always dirty if creating a new tag with a name
-    const id = await onSubmit(getTagInput(values));
+  if (isNew && tag?.name) {
-    if (id) {
+    formik.dirty = true;
-      formik.resetForm({ values });
-      history.push(`/tags/${id}`);
-    }
   }
 
   // set up hotkeys
@@ -130,8 +124,8 @@ export const TagEditPanel: React.FC<ITagEditPanel> = ({
 
       <Prompt
         when={formik.dirty}
-        message={(location) => {
+        message={(location, action) => {
-          if (!isNew && location.pathname.startsWith(`/tags/${tag?.id}`)) {
+          if (action === "PUSH" && location.pathname.startsWith(`/tags/`)) {
             return true;
           }
           return intl.formatMessage({ id: "dialogs.unsaved_changes" });
@@ -260,6 +254,7 @@ export const TagEditPanel: React.FC<ITagEditPanel> = ({
         isEditing={isEditing}
         onToggleEdit={onCancel}
         onSave={() => formik.handleSubmit()}
+        saveDisabled={!formik.dirty}
         onImageChange={onImageChange}
         onImageChangeURL={setImage}
         onClearImage={() => {