Cleanup fixes (#1422)

* cleanup: remove dead code

removing some code that does nothing

* cleanup: fixing usage of deprecated gqlgen/graphql api in api/changeset_translator

* cleanup: changing to recommended comparison methods

Changing byte and case-insensitive string comparison to the recommended methods.

* cleanup: making staticcheck happy
This commit is contained in:
EnameEtavir
2021-05-25 03:03:09 +02:00
committed by GitHub
parent d326d4380f
commit 5c4351f338
9 changed files with 8 additions and 24 deletions

View File

@@ -20,7 +20,6 @@ import (
func setCookies(jar *cookiejar.Jar, scraperConfig config) {
driverOptions := scraperConfig.DriverOptions
if driverOptions != nil && !driverOptions.UseCDP {
var foundURLs []*url.URL
for _, ckURL := range driverOptions.Cookies { // go through all cookies
url, err := url.Parse(ckURL.CookieURL) // CookieURL must be valid, include schema
@@ -44,12 +43,8 @@ func setCookies(jar *cookiejar.Jar, scraperConfig config) {
if jar.Cookies(url) == nil {
logger.Warnf("Setting jar cookies for %s failed", url.String())
} else {
foundURLs = append(foundURLs, url)
}
}
}
}
}