Mirrors/stash
1
0
Fork 0
mirror of https://github.com/stashapp/stash.git synced 2025-12-17 04:14:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

SQLite model refactoring, part 2 (#3839)

Browse Source 
* Treat empty image input as null
* Add validation to models.Date
* Allow zero dates in database
* Make scene_markers.scene_id non-nullable
* Drop scraped_items table
* Remove movie/studio checksum
* Add migration notes
---------
Co-authored-by: WithoutPants <53250216+WithoutPants@users.noreply.github.com>
This commit is contained in:
DingDongSoLong4
2023-07-13 04:15:02 +02:00
committed by GitHub
parent 67d4f9729a
commit 5580525c2d
74 changed files with 520 additions and 807 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/sqlite/gallery_test.go
View File

@@ -62,7 +62,7 @@ func Test_galleryQueryBuilder_Create(t *testing.T) {
galleryFile = makeFileWithID(fileIdxStartGalleryFiles)
)
date := models.NewDate("2003-02-01")
date, _ := models.ParseDate("2003-02-01")
tests := []struct {
name string
@@ -211,7 +211,7 @@ func Test_galleryQueryBuilder_Update(t *testing.T) {
updatedAt = time.Date(2001, 1, 1, 0, 0, 0, 0, time.UTC)
)
date := models.NewDate("2003-02-01")
date, _ := models.ParseDate("2003-02-01")
tests := []struct {
name string
@@ -403,7 +403,7 @@ func Test_galleryQueryBuilder_UpdatePartial(t *testing.T) {
createdAt = time.Date(2001, 1, 1, 0, 0, 0, 0, time.UTC)
updatedAt = time.Date(2001, 1, 1, 0, 0, 0, 0, time.UTC)
date = models.NewDate("2003-02-01")
date, _ = models.ParseDate("2003-02-01")
)
tests := []struct {
@@ -844,10 +844,6 @@ func makeGalleryWithID(index int) *models.Gallery {
ret := makeGallery(index, includeScenes)
ret.ID = galleryIDs[index]
if ret.Date != nil && ret.Date.IsZero() {
ret.Date = nil
}
ret.Files = models.NewRelatedFiles([]file.File{makeGalleryFile(index)})
return ret
@@ -1932,12 +1928,12 @@ func TestGalleryQueryIsMissingDate(t *testing.T) {
galleries := queryGallery(ctx, t, sqb, &galleryFilter, nil)
// three in four scenes have no date
assert.Len(t, galleries, int(math.Ceil(float64(totalGalleries)/4*3)))
// one in four galleries have no date
assert.Len(t, galleries, int(math.Ceil(float64(totalGalleries)/4)))
// ensure date is null, empty or "0001-01-01"
// ensure date is null
for _, g := range galleries {
assert.True(t, g.Date == nil || g.Date.Time == time.Time{})
assert.Nil(t, g.Date)
}
return nil