From 496c36493bbbc4f1f84c14cef2b8ab6fd81b753f Mon Sep 17 00:00:00 2001
From: WithoutPants <53250216+WithoutPants@users.noreply.github.com>
Date: Mon, 20 Mar 2023 12:20:51 +1100
Subject: [PATCH] Fix scan cover defaults (#3564)

* Set generate covers to true during migration
* Default generate cover to true
---
 pkg/sqlite/migrations/45_postmigrate.go               | 10 ++++++++++
 ui/v2.5/src/components/Settings/Tasks/ScanOptions.tsx |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/pkg/sqlite/migrations/45_postmigrate.go b/pkg/sqlite/migrations/45_postmigrate.go
index 8618838a2..ee205788b 100644
--- a/pkg/sqlite/migrations/45_postmigrate.go
+++ b/pkg/sqlite/migrations/45_postmigrate.go
@@ -278,6 +278,16 @@ func (m *schema45Migrator) migrateConfig(ctx context.Context) error {
 		logger.Errorf("Error while writing configuration file: %s", err.Error())
 	}
 
+	// if default scan settings are set, then set to generate scene covers by default
+	scanDefaults := c.GetDefaultScanSettings()
+	if scanDefaults != nil {
+		scanDefaults.ScanGenerateCovers = true
+		c.Set(config.DefaultScanSettings, scanDefaults)
+		if err := c.Write(); err != nil {
+			logger.Errorf("Error while writing configuration file: %s", err.Error())
+		}
+	}
+
 	return nil
 }
 
diff --git a/ui/v2.5/src/components/Settings/Tasks/ScanOptions.tsx b/ui/v2.5/src/components/Settings/Tasks/ScanOptions.tsx
index f8d44dc26..1a965ead3 100644
--- a/ui/v2.5/src/components/Settings/Tasks/ScanOptions.tsx
+++ b/ui/v2.5/src/components/Settings/Tasks/ScanOptions.tsx
@@ -29,7 +29,7 @@ export const ScanOptions: React.FC<IScanOptions> = ({
       <BooleanSetting
         id="scan-generate-covers"
         headingID="config.tasks.generate_video_covers_during_scan"
-        checked={scanGenerateCovers ?? false}
+        checked={scanGenerateCovers ?? true}
         onChange={(v) => setOptions({ scanGenerateCovers: v })}
       />
       <BooleanSetting