Mirrors/stash
1
0
Fork 0
mirror of https://github.com/stashapp/stash.git synced 2025-12-16 20:07:05 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix setting pointers corrupting config in memory (#4868)

Browse Source
This commit is contained in:
WithoutPants
2024-05-23 10:56:18 +10:00
committed by GitHub
parent 77ef16570b
commit 4794a1d453
8 changed files with 238 additions and 287 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/sqlite/migrations/45_postmigrate.go
View File

@@ -273,7 +273,7 @@ func (m *schema45Migrator) migrateConfig(ctx context.Context) error {
}
logger.Infof("Setting blobs storage to %s", defaultStorage.String())
c.Set(config.BlobsStorage, defaultStorage)
c.SetInterface(config.BlobsStorage, defaultStorage)
if err := c.Write(); err != nil {
logger.Errorf("Error while writing configuration file: %s", err.Error())
}
@@ -282,7 +282,7 @@ func (m *schema45Migrator) migrateConfig(ctx context.Context) error {
scanDefaults := c.GetDefaultScanSettings()
if scanDefaults != nil {
scanDefaults.ScanGenerateCovers = true
c.Set(config.DefaultScanSettings, scanDefaults)
c.SetInterface(config.DefaultScanSettings, scanDefaults)
if err := c.Write(); err != nil {
logger.Errorf("Error while writing configuration file: %s", err.Error())
}

2
pkg/sqlite/migrations/58_postmigrate.go
View File

@@ -130,7 +130,7 @@ func (m *schema58Migrator) migrateConfig() error {
newPlugins[key] = m.fromSnakeCaseMap(value)
}
c.Set(config.PluginsSetting, newPlugins)
c.SetInterface(config.PluginsSetting, newPlugins)
if err := c.Write(); err != nil {
return fmt.Errorf("failed to write config: %w", err)
}