Mirrors/stash
1
0
Fork 0
mirror of https://github.com/stashapp/stash.git synced 2025-12-17 20:34:37 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix z-index of performer scrape selector and correct no options message (#1050)

Browse Source
This commit is contained in:
InfiniteTF
2021-01-12 05:05:01 +01:00
committed by GitHub
parent 0a123548a0
commit 3d83fa449d
4 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ui/v2.5/src/components/Changelog/versions/v050.md
View File

@@ -21,6 +21,7 @@
* Support configurable number of threads for scanning and generation. * Support configurable number of threads for scanning and generation.
### 🐛 Bug fixes ### 🐛 Bug fixes
* Fixed performer scraper select overlapping search results
* Fix tag/studio images not being changed after update. * Fix tag/studio images not being changed after update.
* Fixed resolution tags and querying for portrait videos and images. * Fixed resolution tags and querying for portrait videos and images.
* Corrected file sizes on 32bit platforms * Corrected file sizes on 32bit platforms

6
ui/v2.5/src/components/Performers/PerformerDetails/PerformerDetailsPanel.tsx
View File

@@ -397,9 +397,9 @@ export const PerformerDetailsPanel: React.FC<IPerformerDetails> = ({
} }
const popover = ( const popover = (
<Popover id="scraper-popover"> <Popover id="performer-scraper-popover">
<Popover.Content> <Popover.Content>
<div> <>
{queryableScrapers {queryableScrapers
? queryableScrapers.map((s) => ( ? queryableScrapers.map((s) => (
<div key={s.name}> <div key={s.name}>
@@ -421,7 +421,7 @@ export const PerformerDetailsPanel: React.FC<IPerformerDetails> = ({
<span>Reload scrapers</span> <span>Reload scrapers</span>
</Button> </Button>
</div> </div>
</div> </>
</Popover.Content> </Popover.Content>
</Popover> </Popover>
); );

4
ui/v2.5/src/components/Performers/styles.scss
View File

@@ -88,3 +88,7 @@
margin-top: 10px; margin-top: 10px;
max-width: 100%; max-width: 100%;
} }
#performer-scraper-popover {
z-index: 1;
}

5
ui/v2.5/src/components/Shared/Select.tsx
View File

@@ -63,6 +63,7 @@ interface ISelectProps {
showDropdown?: boolean; showDropdown?: boolean;
groupHeader?: string; groupHeader?: string;
closeMenuOnSelect?: boolean; closeMenuOnSelect?: boolean;
noOptionsMessage?: string | null;
} }
interface IFilterComponentProps extends IFilterProps { interface IFilterComponentProps extends IFilterProps {
items: Array<ValidTypes>; items: Array<ValidTypes>;
@@ -106,6 +107,7 @@ const SelectComponent: React.FC<ISelectProps & ITypeProps> = ({
showDropdown = true, showDropdown = true,
groupHeader, groupHeader,
closeMenuOnSelect = true, closeMenuOnSelect = true,
noOptionsMessage = type !== "tags" ? "None" : null,
}) => { }) => {
const defaultValue = const defaultValue =
items.filter((item) => initialIds?.indexOf(item.value) !== -1) ?? null; items.filter((item) => initialIds?.indexOf(item.value) !== -1) ?? null;
@@ -143,7 +145,7 @@ const SelectComponent: React.FC<ISelectProps & ITypeProps> = ({
isMulti, isMulti,
isClearable, isClearable,
defaultValue, defaultValue,
noOptionsMessage: () => (type !== "tags" ? "None" : null), noOptionsMessage: () => noOptionsMessage,
placeholder: isDisabled ? "" : placeholder, placeholder: isDisabled ? "" : placeholder,
onInputChange, onInputChange,
isDisabled, isDisabled,
@@ -312,6 +314,7 @@ export const ScrapePerformerSuggest: React.FC<IScrapePerformerSuggestProps> = (
placeholder={props.placeholder} placeholder={props.placeholder}
className="select-suggest" className="select-suggest"
showDropdown={false} showDropdown={false}
noOptionsMessage={query === "" ? null : "No performers found."}
/> />
); );
}; };