Fixes

Various fixes from Discord discussions.

pkg/ffmpeg/encoder_scene_preview_chunk.go

@@ -28,6 +28,7 @@ func (e *Encoder) ScenePreviewVideoChunk(probeResult VideoFile, options ScenePre
 		"-vf", fmt.Sprintf("scale=%v:-2", options.Width),
 		"-c:a", "aac",
 		"-b:a", "128k",
+		"-strict", "-2",
 		options.OutputPath,
 	}
 	_, _ = e.run(probeResult, args)

pkg/ffmpeg/encoder_transcode.go

@@ -14,6 +14,7 @@ func (e *Encoder) Transcode(probeResult VideoFile, options TranscodeOptions) {
 		"-crf", "23",
 		"-vf", "scale=iw:-2",
 		"-c:a", "aac",
+		"-strict", "-2",
 		options.OutputPath,
 	}
 	_, _ = e.run(probeResult, args)

pkg/manager/generator.go

@@ -1,11 +1,14 @@
 package manager
 
 import (
+	"bytes"
 	"fmt"
 	"github.com/stashapp/stash/pkg/ffmpeg"
 	"github.com/stashapp/stash/pkg/logger"
 	"github.com/stashapp/stash/pkg/utils"
 	"os/exec"
+	"regexp"
+	"runtime"
 	"strconv"
 )
 
@@ -45,16 +48,42 @@ func (g *GeneratorInfo) configure() error {
 
 	numberOfFrames, _ := strconv.Atoi(videoStream.NbFrames)
 	if numberOfFrames == 0 {
-		command := `ffmpeg -nostats -i ` + g.VideoFile.Path + ` -vcodec copy -f rawvideo -y /dev/null 2>&1 | \
+		args := []string{
-                       grep frame | \
+			"-nostats",
-                       awk '{split($0,a,"fps")}END{print a[1]}' | \
+			"-i", g.VideoFile.Path,
-                       sed 's/.*= *//'`
+			"-vcodec", "copy",
-		commandResult, _ := exec.Command(command).Output()
+			"-f", "rawvideo",
-		numberOfFrames, _ := strconv.Atoi(string(commandResult))
+			"-y",
+		}
+		if runtime.GOOS == "windows" {
+			args = append(args, "nul") // https://stackoverflow.com/questions/313111/is-there-a-dev-null-on-windows
+		} else {
+			args = append(args, "/dev/null")
+		}
+
+		command := exec.Command(instance.FFMPEGPath, args...)
+		var stdErrBuffer bytes.Buffer
+		command.Stderr = &stdErrBuffer // Frames go to stderr rather than stdout
+		if err := command.Run(); err == nil {
+			re := regexp.MustCompile(`frame[=] ([0-9]+)`)
+			frames := re.FindStringSubmatch(stdErrBuffer.String())
+			if frames != nil && len(frames) > 1 {
+				numberOfFrames, _ = strconv.Atoi(frames[1])
+			}
+		}
+	}
 	if numberOfFrames == 0 { // TODO: test
 		numberOfFrames = int(framerate * g.VideoFile.Duration)
 	}
+	if numberOfFrames == 0 {
+		logger.Errorf(
+			"number of frames is 0.  nb_frames <%s> framerate <%s> duration <%s>",
+			videoStream.NbFrames,
+			framerate,
+			g.VideoFile.Duration,
+			)
 	}
+
 	g.NumberOfFrames = numberOfFrames
 	g.NthFrame = g.NumberOfFrames / g.ChunkCount
 

pkg/manager/generator_sprite.go

@@ -81,6 +81,7 @@ func (g *SpriteGenerator) generateSpriteImage(encoder *ffmpeg.Encoder) error {
 	// Combine all of the thumbnails into a sprite image
 	globPath := filepath.Join(instance.Paths.Generated.Tmp, "thumbnail*.jpg")
 	imagePaths, _ := doublestar.Glob(globPath)
+	utils.NaturalSort(imagePaths)
 	var images []image.Image
 	for _, imagePath := range imagePaths {
 		img, err := imaging.Open(imagePath)

pkg/manager/manager_tasks.go

@@ -21,7 +21,7 @@ func (s *singleton) Scan() {
 
 		var results []string
 		for _, path := range config.GetStashPaths() {
-			globPath := filepath.Join(path, "**/*.{zip,m4v,mp4,mov,wmv,avi}")
+			globPath := filepath.Join(path, "**/*.{zip,m4v,mp4,mov,wmv,avi,mpg,mpeg,rmvb,rm,flv,asf,mkv,webm}") // TODO: Make this configurable
 			globResults, _ := doublestar.Glob(globPath)
 			results = append(results, globResults...)
 		}