Revert "Upgrade to go 1.19 and update dependencies (#3069)" (#3085)

This reverts commit bba7c23957.

vendor/github.com/urfave/cli/v2/flag.go

@@ -5,6 +5,7 @@ import (
 	"flag"
 	"fmt"
 	"io/ioutil"
+	"reflect"
 	"regexp"
 	"runtime"
 	"strconv"
@@ -116,12 +117,6 @@ type DocGenerationFlag interface {
 	// GetValue returns the flags value as string representation and an empty
 	// string if the flag takes no value at all.
 	GetValue() string
-
-	// GetDefaultText returns the default text for this flag
-	GetDefaultText() string
-
-	// GetEnvVars returns the env vars for this flag
-	GetEnvVars() []string
 }
 
 // VisibleFlag is an interface that allows to check if a flag is visible
@@ -132,14 +127,6 @@ type VisibleFlag interface {
 	IsVisible() bool
 }
 
-// CategorizableFlag is an interface that allows us to potentially
-// use a flag in a categorized representation.
-type CategorizableFlag interface {
-	VisibleFlag
-
-	GetCategory() string
-}
-
 func flagSet(name string, flags []Flag) (*flag.FlagSet, error) {
 	set := flag.NewFlagSet(name, flag.ContinueOnError)
 
@@ -251,7 +238,7 @@ func prefixedNames(names []string, placeholder string) string {
 
 func withEnvHint(envVars []string, str string) string {
 	envText := ""
-	if len(envVars) > 0 {
+	if envVars != nil && len(envVars) > 0 {
 		prefix := "$"
 		suffix := ""
 		sep := ", $"
@@ -266,7 +253,7 @@ func withEnvHint(envVars []string, str string) string {
 	return str + envText
 }
 
-func FlagNames(name string, aliases []string) []string {
+func flagNames(name string, aliases []string) []string {
 	var ret []string
 
 	for _, part := range append([]string{name}, aliases...) {
@@ -280,6 +267,17 @@ func FlagNames(name string, aliases []string) []string {
 	return ret
 }
 
+func flagStringSliceField(f Flag, name string) []string {
+	fv := flagValue(f)
+	field := fv.FieldByName(name)
+
+	if field.IsValid() {
+		return field.Interface().([]string)
+	}
+
+	return []string{}
+}
+
 func withFileHint(filePath, str string) string {
 	fileText := ""
 	if filePath != "" {
@@ -288,34 +286,68 @@ func withFileHint(filePath, str string) string {
 	return str + fileText
 }
 
+func flagValue(f Flag) reflect.Value {
+	fv := reflect.ValueOf(f)
+	for fv.Kind() == reflect.Ptr {
+		fv = reflect.Indirect(fv)
+	}
+	return fv
+}
+
 func formatDefault(format string) string {
 	return " (default: " + format + ")"
 }
 
 func stringifyFlag(f Flag) string {
-	// enforce DocGeneration interface on flags to avoid reflection
-	df, ok := f.(DocGenerationFlag)
-	if !ok {
-		return ""
+	fv := flagValue(f)
+
+	switch f := f.(type) {
+	case *IntSliceFlag:
+		return withEnvHint(flagStringSliceField(f, "EnvVars"),
+			stringifyIntSliceFlag(f))
+	case *Int64SliceFlag:
+		return withEnvHint(flagStringSliceField(f, "EnvVars"),
+			stringifyInt64SliceFlag(f))
+	case *Float64SliceFlag:
+		return withEnvHint(flagStringSliceField(f, "EnvVars"),
+			stringifyFloat64SliceFlag(f))
+	case *StringSliceFlag:
+		return withEnvHint(flagStringSliceField(f, "EnvVars"),
+			stringifyStringSliceFlag(f))
 	}
 
-	placeholder, usage := unquoteUsage(df.GetUsage())
-	needsPlaceholder := df.TakesValue()
+	placeholder, usage := unquoteUsage(fv.FieldByName("Usage").String())
+
+	needsPlaceholder := false
+	defaultValueString := ""
+	val := fv.FieldByName("Value")
+	if val.IsValid() {
+		needsPlaceholder = val.Kind() != reflect.Bool
+		defaultValueString = fmt.Sprintf(formatDefault("%v"), val.Interface())
+
+		if val.Kind() == reflect.String && val.String() != "" {
+			defaultValueString = fmt.Sprintf(formatDefault("%q"), val.String())
+		}
+	}
+
+	helpText := fv.FieldByName("DefaultText")
+	if helpText.IsValid() && helpText.String() != "" {
+		needsPlaceholder = val.Kind() != reflect.Bool
+		defaultValueString = fmt.Sprintf(formatDefault("%s"), helpText.String())
+	}
+
+	if defaultValueString == formatDefault("") {
+		defaultValueString = ""
+	}
 
 	if needsPlaceholder && placeholder == "" {
 		placeholder = defaultPlaceholder
 	}
 
-	defaultValueString := ""
-
-	if s := df.GetDefaultText(); s != "" {
-		defaultValueString = fmt.Sprintf(formatDefault("%s"), s)
-	}
-
 	usageWithDefault := strings.TrimSpace(usage + defaultValueString)
 
-	return withEnvHint(df.GetEnvVars(),
-		fmt.Sprintf("%s\t%s", prefixedNames(df.Names(), placeholder), usageWithDefault))
+	return withEnvHint(flagStringSliceField(f, "EnvVars"),
+		fmt.Sprintf("%s\t%s", prefixedNames(f.Names(), placeholder), usageWithDefault))
 }
 
 func stringifyIntSliceFlag(f *IntSliceFlag) string {
@@ -394,26 +426,19 @@ func hasFlag(flags []Flag, fl Flag) bool {
 	return false
 }
 
-// Return the first value from a list of environment variables and files
-// (which may or may not exist), a description of where the value was found,
-// and a boolean which is true if a value was found.
-func flagFromEnvOrFile(envVars []string, filePath string) (value string, fromWhere string, found bool) {
+func flagFromEnvOrFile(envVars []string, filePath string) (val string, ok bool) {
 	for _, envVar := range envVars {
 		envVar = strings.TrimSpace(envVar)
-		if value, found := syscall.Getenv(envVar); found {
-			return value, fmt.Sprintf("environment variable %q", envVar), true
+		if val, ok := syscall.Getenv(envVar); ok {
+			return val, true
 		}
 	}
 	for _, fileVar := range strings.Split(filePath, ",") {
 		if fileVar != "" {
 			if data, err := ioutil.ReadFile(fileVar); err == nil {
-				return string(data), fmt.Sprintf("file %q", filePath), true
+				return string(data), true
 			}
 		}
 	}
-	return "", "", false
-}
-
-func flagSplitMultiValues(val string) []string {
-	return strings.Split(val, ",")
+	return "", false
 }