Model refactor, part 2 (#4092)

* Move conversions into changesetTranslator
* Improve mutation error messages
* Use models.New and models.NewPartial everywhere
* Replace getStashIDsFor functions
* Remove ImageCreateInput
* Remove unused parameters
* Refactor matching functions
---------
Co-authored-by: WithoutPants <53250216+WithoutPants@users.noreply.github.com>

pkg/models/model_scene.go

@@ -48,6 +48,50 @@ type Scene struct {
 	StashIDs     RelatedStashIDs `json:"stash_ids"`
 }
 
+func NewScene() Scene {
+	currentTime := time.Now()
+	return Scene{
+		CreatedAt: currentTime,
+		UpdatedAt: currentTime,
+	}
+}
+
+// ScenePartial represents part of a Scene object. It is used to update
+// the database entry.
+type ScenePartial struct {
+	Title    OptionalString
+	Code     OptionalString
+	Details  OptionalString
+	Director OptionalString
+	Date     OptionalDate
+	// Rating expressed in 1-100 scale
+	Rating       OptionalInt
+	Organized    OptionalBool
+	OCounter     OptionalInt
+	StudioID     OptionalInt
+	CreatedAt    OptionalTime
+	UpdatedAt    OptionalTime
+	ResumeTime   OptionalFloat64
+	PlayDuration OptionalFloat64
+	PlayCount    OptionalInt
+	LastPlayedAt OptionalTime
+
+	URLs          *UpdateStrings
+	GalleryIDs    *UpdateIDs
+	TagIDs        *UpdateIDs
+	PerformerIDs  *UpdateIDs
+	MovieIDs      *UpdateMovieIDs
+	StashIDs      *UpdateStashIDs
+	PrimaryFileID *FileID
+}
+
+func NewScenePartial() ScenePartial {
+	currentTime := time.Now()
+	return ScenePartial{
+		UpdatedAt: NewOptionalTime(currentTime),
+	}
+}
+
 func (s *Scene) LoadURLs(ctx context.Context, l URLLoader) error {
 	return s.URLs.load(func() ([]string, error) {
 		return l.GetURLs(ctx, s.ID)
@@ -145,77 +189,6 @@ func (s *Scene) LoadRelationships(ctx context.Context, l SceneReader) error {
 	return nil
 }
 
-// ScenePartial represents part of a Scene object. It is used to update
-// the database entry.
-type ScenePartial struct {
-	Title    OptionalString
-	Code     OptionalString
-	Details  OptionalString
-	Director OptionalString
-	Date     OptionalDate
-	// Rating expressed in 1-100 scale
-	Rating       OptionalInt
-	Organized    OptionalBool
-	OCounter     OptionalInt
-	StudioID     OptionalInt
-	CreatedAt    OptionalTime
-	UpdatedAt    OptionalTime
-	ResumeTime   OptionalFloat64
-	PlayDuration OptionalFloat64
-	PlayCount    OptionalInt
-	LastPlayedAt OptionalTime
-
-	URLs          *UpdateStrings
-	GalleryIDs    *UpdateIDs
-	TagIDs        *UpdateIDs
-	PerformerIDs  *UpdateIDs
-	MovieIDs      *UpdateMovieIDs
-	StashIDs      *UpdateStashIDs
-	PrimaryFileID *FileID
-}
-
-func NewScenePartial() ScenePartial {
-	updatedTime := time.Now()
-	return ScenePartial{
-		UpdatedAt: NewOptionalTime(updatedTime),
-	}
-}
-
-type SceneMovieInput struct {
-	MovieID    string `json:"movie_id"`
-	SceneIndex *int   `json:"scene_index"`
-}
-
-type SceneUpdateInput struct {
-	ClientMutationID *string `json:"clientMutationId"`
-	ID               string  `json:"id"`
-	Title            *string `json:"title"`
-	Code             *string `json:"code"`
-	Details          *string `json:"details"`
-	Director         *string `json:"director"`
-	URL              *string `json:"url"`
-	Date             *string `json:"date"`
-	// Rating expressed in 1-5 scale
-	Rating *int `json:"rating"`
-	// Rating expressed in 1-100 scale
-	Rating100    *int               `json:"rating100"`
-	OCounter     *int               `json:"o_counter"`
-	Organized    *bool              `json:"organized"`
-	Urls         []string           `json:"urls"`
-	StudioID     *string            `json:"studio_id"`
-	GalleryIds   []string           `json:"gallery_ids"`
-	PerformerIds []string           `json:"performer_ids"`
-	Movies       []*SceneMovieInput `json:"movies"`
-	TagIds       []string           `json:"tag_ids"`
-	// This should be a URL or a base64 encoded data URL
-	CoverImage    *string   `json:"cover_image"`
-	StashIds      []StashID `json:"stash_ids"`
-	ResumeTime    *float64  `json:"resume_time"`
-	PlayDuration  *float64  `json:"play_duration"`
-	PlayCount     *int      `json:"play_count"`
-	PrimaryFileID *string   `json:"primary_file_id"`
-}
-
 // UpdateInput constructs a SceneUpdateInput using the populated fields in the ScenePartial object.
 func (s ScenePartial) UpdateInput(id int) SceneUpdateInput {
 	var dateStr *string
@@ -302,16 +275,6 @@ type SceneFileType struct {
 	Bitrate    *int     `graphql:"bitrate" json:"bitrate"`
 }
 
-type Scenes []*Scene
-
-func (s *Scenes) Append(o interface{}) {
-	*s = append(*s, o.(*Scene))
-}
-
-func (s *Scenes) New() interface{} {
-	return &Scene{}
-}
-
 type VideoCaption struct {
 	LanguageCode string `json:"language_code"`
 	Filename     string `json:"filename"`