Fix bulk performer tagger (#4024)

* Fix tagger modal checkboxes
* Fix UNIQUE constraint detection
* Performer tagger cache invalidation
* Fix batch performer tagger
* Use ToPerformer in identify
* Add missing excluded fields
* Internationalize excluded fields
* Replace deprecated substr()
* Check RemoteSiteID nil

pkg/models/model_scraped_item_test.go

@@ -1,6 +1,7 @@
 package models
 
 import (
+	"strconv"
 	"testing"
 	"time"
 
@@ -10,12 +11,15 @@ import (
 func Test_scrapedToStudioInput(t *testing.T) {
 	const name = "name"
 	url := "url"
+	emptyEndpoint := ""
+	endpoint := "endpoint"
 	remoteSiteID := "remoteSiteID"
 
 	tests := []struct {
-		name   string
-		studio *ScrapedStudio
-		want   *Studio
+		name     string
+		studio   *ScrapedStudio
+		endpoint string
+		want     *Studio
 	}{
 		{
 			"set all",
@@ -24,27 +28,51 @@ func Test_scrapedToStudioInput(t *testing.T) {
 				URL:          &url,
 				RemoteSiteID: &remoteSiteID,
 			},
+			endpoint,
 			&Studio{
 				Name: name,
 				URL:  url,
 				StashIDs: NewRelatedStashIDs([]StashID{
 					{
-						StashID: remoteSiteID,
+						Endpoint: endpoint,
+						StashID:  remoteSiteID,
 					},
 				}),
 			},
 		},
 		{
 			"set none",
+			&ScrapedStudio{
+				Name: name,
+			},
+			emptyEndpoint,
+			&Studio{
+				Name: name,
+			},
+		},
+		{
+			"missing remoteSiteID",
+			&ScrapedStudio{
+				Name: name,
+			},
+			endpoint,
+			&Studio{
+				Name: name,
+			},
+		},
+		{
+			"set stashid",
 			&ScrapedStudio{
 				Name:         name,
 				RemoteSiteID: &remoteSiteID,
 			},
+			endpoint,
 			&Studio{
 				Name: name,
 				StashIDs: NewRelatedStashIDs([]StashID{
 					{
-						StashID: remoteSiteID,
+						Endpoint: endpoint,
+						StashID:  remoteSiteID,
 					},
 				}),
 			},
@@ -52,7 +80,165 @@ func Test_scrapedToStudioInput(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			got := tt.studio.ToStudio("", nil)
+			got := tt.studio.ToStudio(tt.endpoint, nil)
+
+			assert.NotEqual(t, time.Time{}, got.CreatedAt)
+			assert.NotEqual(t, time.Time{}, got.UpdatedAt)
+
+			got.CreatedAt = time.Time{}
+			got.UpdatedAt = time.Time{}
+			assert.Equal(t, tt.want, got)
+		})
+	}
+}
+
+func Test_scrapedToPerformerInput(t *testing.T) {
+	name := "name"
+	emptyEndpoint := ""
+	endpoint := "endpoint"
+	remoteSiteID := "remoteSiteID"
+
+	var stringValues []string
+	for i := 0; i < 20; i++ {
+		stringValues = append(stringValues, strconv.Itoa(i))
+	}
+
+	upTo := 0
+	nextVal := func() *string {
+		ret := stringValues[upTo]
+		upTo = (upTo + 1) % len(stringValues)
+		return &ret
+	}
+
+	nextIntVal := func() *int {
+		ret := upTo
+		upTo = (upTo + 1) % len(stringValues)
+		return &ret
+	}
+
+	dateFromInt := func(i int) *Date {
+		t := time.Date(2001, 1, i, 0, 0, 0, 0, time.UTC)
+		d := Date{Time: t}
+		return &d
+	}
+	dateStrFromInt := func(i int) *string {
+		s := dateFromInt(i).String()
+		return &s
+	}
+
+	genderFromInt := func(i int) *GenderEnum {
+		g := AllGenderEnum[i%len(AllGenderEnum)]
+		return &g
+	}
+	genderStrFromInt := func(i int) *string {
+		s := genderFromInt(i).String()
+		return &s
+	}
+
+	tests := []struct {
+		name      string
+		performer *ScrapedPerformer
+		endpoint  string
+		want      *Performer
+	}{
+		{
+			"set all",
+			&ScrapedPerformer{
+				Name:           &name,
+				Disambiguation: nextVal(),
+				Birthdate:      dateStrFromInt(*nextIntVal()),
+				DeathDate:      dateStrFromInt(*nextIntVal()),
+				Gender:         genderStrFromInt(*nextIntVal()),
+				Ethnicity:      nextVal(),
+				Country:        nextVal(),
+				EyeColor:       nextVal(),
+				HairColor:      nextVal(),
+				Height:         nextVal(),
+				Weight:         nextVal(),
+				Measurements:   nextVal(),
+				FakeTits:       nextVal(),
+				CareerLength:   nextVal(),
+				Tattoos:        nextVal(),
+				Piercings:      nextVal(),
+				Aliases:        nextVal(),
+				Twitter:        nextVal(),
+				Instagram:      nextVal(),
+				URL:            nextVal(),
+				Details:        nextVal(),
+				RemoteSiteID:   &remoteSiteID,
+			},
+			endpoint,
+			&Performer{
+				Name:           name,
+				Disambiguation: *nextVal(),
+				Birthdate:      dateFromInt(*nextIntVal()),
+				DeathDate:      dateFromInt(*nextIntVal()),
+				Gender:         genderFromInt(*nextIntVal()),
+				Ethnicity:      *nextVal(),
+				Country:        *nextVal(),
+				EyeColor:       *nextVal(),
+				HairColor:      *nextVal(),
+				Height:         nextIntVal(),
+				Weight:         nextIntVal(),
+				Measurements:   *nextVal(),
+				FakeTits:       *nextVal(),
+				CareerLength:   *nextVal(),
+				Tattoos:        *nextVal(),
+				Piercings:      *nextVal(),
+				Aliases:        NewRelatedStrings([]string{*nextVal()}),
+				Twitter:        *nextVal(),
+				Instagram:      *nextVal(),
+				URL:            *nextVal(),
+				Details:        *nextVal(),
+				StashIDs: NewRelatedStashIDs([]StashID{
+					{
+						Endpoint: endpoint,
+						StashID:  remoteSiteID,
+					},
+				}),
+			},
+		},
+		{
+			"set none",
+			&ScrapedPerformer{
+				Name: &name,
+			},
+			emptyEndpoint,
+			&Performer{
+				Name: name,
+			},
+		},
+		{
+			"missing remoteSiteID",
+			&ScrapedPerformer{
+				Name: &name,
+			},
+			endpoint,
+			&Performer{
+				Name: name,
+			},
+		},
+		{
+			"set stashid",
+			&ScrapedPerformer{
+				Name:         &name,
+				RemoteSiteID: &remoteSiteID,
+			},
+			endpoint,
+			&Performer{
+				Name: name,
+				StashIDs: NewRelatedStashIDs([]StashID{
+					{
+						Endpoint: endpoint,
+						StashID:  remoteSiteID,
+					},
+				}),
+			},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := tt.performer.ToPerformer(tt.endpoint, nil)
 
 			assert.NotEqual(t, time.Time{}, got.CreatedAt)
 			assert.NotEqual(t, time.Time{}, got.UpdatedAt)