From 2925325e68d9fba64ca9952569b1010415898fb0 Mon Sep 17 00:00:00 2001 From: WithoutPants <53250216+WithoutPants@users.noreply.github.com> Date: Thu, 6 Nov 2025 16:54:53 +1100 Subject: [PATCH 1/2] Fix contents not loading in filter sidebar (#6240) --- .../List/Filters/SidebarListFilter.tsx | 3 +++ ui/v2.5/src/components/Shared/Sidebar.tsx | 16 +++++++++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/ui/v2.5/src/components/List/Filters/SidebarListFilter.tsx b/ui/v2.5/src/components/List/Filters/SidebarListFilter.tsx index 6754787db..fe9b7987c 100644 --- a/ui/v2.5/src/components/List/Filters/SidebarListFilter.tsx +++ b/ui/v2.5/src/components/List/Filters/SidebarListFilter.tsx @@ -275,6 +275,7 @@ export const SidebarListFilter: React.FC<{ postSelected?: React.ReactNode; preCandidates?: React.ReactNode; postCandidates?: React.ReactNode; + onOpen?: () => void; // used to store open/closed state in SidebarStateContext sectionID?: string; }> = ({ @@ -292,6 +293,7 @@ export const SidebarListFilter: React.FC<{ postCandidates, preSelected, postSelected, + onOpen, sectionID, }) => { // TODO - sort items? @@ -344,6 +346,7 @@ export const SidebarListFilter: React.FC<{ {postSelected ?
{postSelected}
: null} } + onOpen={onOpen} > {preCandidates ?
{preCandidates}
: null} void; // used to store open/closed state in SidebarStateContext sectionID?: string; }> -> = ({ className = "", text, outsideCollapse, sectionID = "", children }) => { +> = ({ + className = "", + text, + outsideCollapse, + onOpen, + sectionID = "", + children, +}) => { // this is optional const contextState = React.useContext(SidebarStateContext); const openState = @@ -93,6 +101,12 @@ export const SidebarSection: React.FC< } } + useEffect(() => { + if (openState && onOpen) { + onOpen(); + } + }, [openState, onOpen]); + const collapseProps: Partial = { mountOnEnter: true, unmountOnExit: true, From 7716c4dd874512e7937c59ee52d034e452ba2026 Mon Sep 17 00:00:00 2001 From: WithoutPants <53250216+WithoutPants@users.noreply.github.com> Date: Thu, 6 Nov 2025 16:55:40 +1100 Subject: [PATCH 2/2] Update changelog --- ui/v2.5/src/docs/en/Changelog/v0290.md | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/v2.5/src/docs/en/Changelog/v0290.md b/ui/v2.5/src/docs/en/Changelog/v0290.md index f08c4aec1..51ca93e5d 100644 --- a/ui/v2.5/src/docs/en/Changelog/v0290.md +++ b/ui/v2.5/src/docs/en/Changelog/v0290.md @@ -33,6 +33,7 @@ * Include IP address in login errors in log. ([#5760](https://github.com/stashapp/stash/pull/5760)) ### 🐛 Bug fixes +* **[0.29.3]** Fixed sidebar filter contents not loading. ([#6240](https://github.com/stashapp/stash/pull/6240)) * **[0.29.2]** Fixed Play Random not playing from the current filtered scenes on scene list sub-pages. ([#6202](https://github.com/stashapp/stash/pull/6202)) * **[0.29.2]** Fixed infinite loop in Group Sub-Groups panel. ([#6212](https://github.com/stashapp/stash/pull/6212)) * **[0.29.2]** Page no longer scrolls when selecting criterion for the first time in the Edit Filter dialog. ([#6205](https://github.com/stashapp/stash/pull/6205))