Mirrors/modern-cpp-features
1
0
Fork 0
mirror of https://github.com/AnthonyCalandra/modern-cpp-features.git synced 2025-12-18 10:34:35 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Typo in std::make_shared section.

Browse Source
This commit is contained in:
Anthony Calandra
2017-06-25 15:07:35 -04:00
parent 89427e964a
commit c4431e1c38
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
README.md
View File

@@ -1254,9 +1254,9 @@ These containers maintain average constant-time complexity for search, insert, a
```c++ ```c++
foo(std::shared_ptr<T>{ new T{} }, function_that_throws(), std::shared_ptr<T>{ new T{} }); foo(std::shared_ptr<T>{ new T{} }, function_that_throws(), std::shared_ptr<T>{ new T{} });
``` ```
The compiler is free to call `new T{}`, then `function_that_throws()`, and so on... Since we have allocated data on the heap in the first construction of a `T`, we have introduced a leak here. With `std::make_unique`, we are given exception-safety: The compiler is free to call `new T{}`, then `function_that_throws()`, and so on... Since we have allocated data on the heap in the first construction of a `T`, we have introduced a leak here. With `std::make_shared`, we are given exception-safety:
```c++ ```c++
foo(std::make_unique<T>(), function_that_throws(), std::make_unique<T>()); foo(std::make_shared<T>(), function_that_throws(), std::make_shared<T>());
``` ```
* Prevents having to do two allocations. When calling `std::shared_ptr{ new T{} }`, we have to allocate memory for `T`, then in the shared pointer we have to allocate memory for the control block within the pointer. * Prevents having to do two allocations. When calling `std::shared_ptr{ new T{} }`, we have to allocate memory for `T`, then in the shared pointer we have to allocate memory for the control block within the pointer.