refactor the clang format example and add test

04-static-analysis/clang-format/cmake/modules/clang-format.cmake

@@ -1,10 +1,11 @@
 # A CMake script to find all source files and setup clang-format targets for them
 
 # Find all source files
-file(GLOB_RECURSE ALL_SOURCE_FILES *.cpp *.h *.cxx *.hxx *.hpp *.cc)
+set(CLANG_FORMAT_CXX_FILE_EXTENSIONS ${CLANG_FORMAT_CXX_FILE_EXTENSIONS} *.cpp *.h *.cxx *.hxx *.hpp *.cc *.ipp)
+file(GLOB_RECURSE ALL_SOURCE_FILES ${CLANG_FORMAT_CXX_FILE_EXTENSIONS})
 
 # Don't include some common build folders
-set(CLANG_FORMAT_EXCLUDE_PATTERNS ${CLANG_FORMAT_EXCLUDE_PATTERNS} "main2.cpp" "build/" "/CMakeFiles/")
+set(CLANG_FORMAT_EXCLUDE_PATTERNS ${CLANG_FORMAT_EXCLUDE_PATTERNS} "/CMakeFiles/" "cmake")
 
 # get all project files file
 foreach (SOURCE_FILE ${ALL_SOURCE_FILES}) 
@@ -24,21 +25,38 @@ add_custom_target(format
     ${ALL_SOURCE_FILES}
 )
 
+
 add_custom_target(format-check
     COMMENT "Checking clang-format changes"
-    COMMAND ${CLANG_FORMAT_BIN}
+    # Use ! to negate the result for correct output
+    COMMAND !
+    ${CLANG_FORMAT_BIN}
     -style=file
     -output-replacements-xml
     ${ALL_SOURCE_FILES}
-    | grep "replacement offset" 2>&1 > /dev/null
+    | grep -q "replacement offset" 
 )
 
 # Get the path to this file
 get_filename_component(_clangcheckpath ${CMAKE_CURRENT_LIST_FILE} PATH)
+# have at least one here by default
+set(CHANGED_FILE_EXTENSIONS ".cpp")
+foreach(EXTENSION ${CLANG_FORMAT_CXX_FILE_EXTENSIONS})
+    set(CHANGED_FILE_EXTENSIONS "${CHANGED_FILE_EXTENSIONS},${EXTENSION}" )
+endforeach()
+
+set(EXCLUDE_PATTERN_ARGS)
+foreach(EXCLUDE_PATTERN ${CLANG_FORMAT_EXCLUDE_PATTERNS})
+    list(APPEND EXCLUDE_PATTERN_ARGS "--exclude=${EXCLUDE_PATTERN}")
+endforeach()
+
 # call the script to chech changed files in git
 add_custom_target(format-check-changed
     COMMENT "Checking changed files in git"
     WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
-    COMMAND ${_clangcheckpath}/../scripts/clang-format-check-changed ${CLANG_FORMAT_BIN}
+    COMMAND ${_clangcheckpath}/../scripts/clang-format-check-changed.py 
+    --file-extensions \"${CHANGED_FILE_EXTENSIONS}\"
+    ${EXCLUDE_PATTERN_ARGS}
+    --clang-format-bin ${CLANG_FORMAT_BIN}
 )