Mirrors/asmjit
1
0
Fork 0
mirror of https://github.com/asmjit/asmjit.git synced 2025-12-18 13:04:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

[bug] Don't negate a signed number (UB fix)

Browse Source 
* Fixes a potential UB in number to string conversion because of
    a possible undefined behavior caused by -int64_t(a) code. The
    fix replaces the code with Support::neg() function, which was
    designed for exactly this.
This commit is contained in:
kobalicek
2025-02-12 15:55:06 +01:00
parent e1b20711cc
commit 58c585f003
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/asmjit/core/string.cpp
View File

@@ -291,7 +291,7 @@ Error String::_opNumber(ModifyOp op, uint64_t i, uint32_t base, size_t width, St
// ----------- // -----------
if (Support::test(flags, StringFormatFlags::kSigned) && int64_t(i) < 0) { if (Support::test(flags, StringFormatFlags::kSigned) && int64_t(i) < 0) {
i = uint64_t(-int64_t(i)); i = Support::neg(i);
sign = '-'; sign = '-';
} }
else if (Support::test(flags, StringFormatFlags::kShowSign)) { else if (Support::test(flags, StringFormatFlags::kShowSign)) {