Mirrors/asmjit
1
0
Fork 0
mirror of https://github.com/asmjit/asmjit.git synced 2025-12-18 21:14:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

[Bug] Fixed a ModRM/MR check in X86 assembler (mov instruction) (fixes #392)

Browse Source
This commit is contained in:
kobalicek
2022-11-26 00:05:25 +01:00
parent 0c03ed2f74
commit 45f3b764b3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/asmjit/x86/x86assembler.cpp
View File

@@ -493,11 +493,11 @@ static ASMJIT_FORCE_INLINE uint32_t x86GetMovAbsInstSize64Bit(uint32_t regSize,
static ASMJIT_FORCE_INLINE bool x86ShouldUseMovabs(Assembler* self, X86BufferWriter& writer, uint32_t regSize, InstOptions options, const Mem& rmRel) noexcept { static ASMJIT_FORCE_INLINE bool x86ShouldUseMovabs(Assembler* self, X86BufferWriter& writer, uint32_t regSize, InstOptions options, const Mem& rmRel) noexcept {
if (self->is32Bit()) { if (self->is32Bit()) {
// There is no relative addressing, just decide whether to use MOV encoded with MOD R/M or absolute. // There is no relative addressing, just decide whether to use MOV encoded with MOD R/M or absolute.
return !Support::test(options, InstOptions::kX86_ModMR | InstOptions::kX86_ModMR); return !Support::test(options, InstOptions::kX86_ModMR | InstOptions::kX86_ModRM);
} }
else { else {
// If the addressing type is REL or MOD R/M was specified then absolute mov won't be used. // If the addressing type is REL or MOD R/M was specified then absolute mov won't be used.
if (rmRel.addrType() == Mem::AddrType::kRel || Support::test(options, InstOptions::kX86_ModMR)) if (rmRel.addrType() == Mem::AddrType::kRel || Support::test(options, InstOptions::kX86_ModMR | InstOptions::kX86_ModRM))
return false; return false;
int64_t addrValue = rmRel.offset(); int64_t addrValue = rmRel.offset();