mirror of
https://github.com/miurahr/aqtinstall.git
synced 2025-12-17 20:54:38 +03:00
d5213142a8
In an earlier PR, I added calls to `disable_socket()` from `pytest_socket` where I thought they were needed to prevent some tests from accessing the network, in case they weren't monkeypatched properly. Today, I discovered that `disable_socket()` disables sockets globally for all tests, which means that the tests that use remote data cannot run if they are executed after another test calls `disable_socket()`. This change calls `disable_socket()` once from `conftest.py`, so that no tests are allowed to use network data unless they are marked as ok to use the network, with `@pytest.mark.enable_socket`. See example of usage in `tests/test_connection.py`. Changed return code for unexpected exceptions: This allows us to write tests that can discover whether an unexpected exception occurred just by checking the return code, rather than reading stderr. This will allow us to write less friable tests that don't break every time some insignificant output details change. This change catches exceptions derived from Exception and KeyboardInterrupt raised by `installer`, while run by multiple processes, and propagates them back to earlier stack entries. This will prevent any OSError and BrokenPipe exceptions that would otherwise be raised when one process has an exception while the other processes are still running. This also handles the MemoryError exception we saw in #416, and offers some suggestions for solving the issue.
6 lines
92 B
Python
6 lines
92 B
Python
from pytest_socket import disable_socket
|
|
|
|
|
|
def pytest_runtest_setup():
|
|
disable_socket()
|