The original error message, `Download error when access <filename>`,
is confusing when a user is trying to use `aqt list`. This message
could make the user think that `aqt list` is attempting to download
archives, when in reality the command is only reading files on the
server.
Initially, I wanted to make this error message modifiable by the caller.
On further investigation, I realized that this function is always used
to retrieve 'Updates.xml' files or hashes, and that the error message
"Failed to retrieve file" would be appropriate for all usages.
Admittedly, the distinction between "Download error" and "Failed to
retrieve file" is subtle. However, the difference was big enough to
convince me as a developer that I should not use this function to
retrieve "Updates.xml" files, when in fact it was the right function to
use.
This change handles multiple redirects. Without this change, if
`helper.altlink()` returns a url that will redirect, we cannot follow
that redirect. This change allows up to 10 such redirects to occur.
Please note that the upper bound for number of redirects was chosen
arbitrarily, with no regard for what might realistically occur. I felt
that it was important not to allow recursive or infinite redirects, and
that at least two redirects should be allowed. Perhaps the upper bound
should be modifiable in settings.ini.
It apply KDE patch collection to Qt 5.15.2 source
`aqt src 5.15.2 linux desktop --kde`
Patch collection is based on Qt 5.15.2, so only the version can be patched.
Ref #231
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* Use global variable to hold Settings
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* Settings global instance to hold configurations
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* Revert to Settings class to helper module
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* Revert Settings class variables
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* PEP8
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* CI: change actions to use macos-11
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* Revert "CI: change actions to use macos-11"
CI: macos-11 is just for private preview
This reverts commit f1d576f4bf.
* Patch qmake hard coded path with installed prefix(#100)
* AP: Update tests
- Test android target with 5.14.x
- Test ios target on mac
* Does not patch mac framework when android, ios and wasm
* Update changelog
* GHA: Update to run qmake to check patch
- Check qmake works well if patched.
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* Refactoring altlink helper
Also fix a bug not accept a header context-type when
got charset parameter such as
application/meta4+xml; charset=utf-8
* Add test and accept text/plain mime type
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
