* Add authentication flags for list-qt-commercial, add tests for coverage
* Add dry run
* Make tests really use auth since secrets have been added, fix some indents
* Fix auth issue, rename user 'email, and password 'pw'
* Fix modules param type
* Update commands names
* Add install-qt-commercial feature and tests
* Make the auto-answers parameters, fix linter issues
* Fork and execv instead of using subprocess
* Return to simpler process execution method version
* Fix test
* Move commercial installer into its own file
* Fix shadowing of symbol platform causing errors
* Adapt test_cli for argparse format changes on py 3.13+
* Fix some errors, monkeypatch install test
* Add --override super command
* Properly handle --override and grab all the remaining commands when no quotes are given
* Fix tests
* Add base for modules, some niche features are not yet entirely implemented, and there are no updates to the testsuite
* Fix some mistakes
* Fix errors made with the monkeypatch, update Settings to make sure its init
* Tests commercial (#20)
* Full support of installation of all modules and addons
* Add auto setup of cache folder for each OS, add unattended parameter
* Fix settings folders
* Add graceful error message for overwrite case
* Fix windows issue
* Hidden summon works
* Remove both subprocess direct calls
* Dipose of temp folder
* Fix path issue
* Add list-qt-commercial command
* Fix help info
* Make no params valid for list-qt-commercial
* Fix lint errors, and param overflow when no args are passed to list
* Fix search
* Add tests for coverage, fix lint
* Test for overwriting, and for cache usage coverage
* Return to clean exec, ignoring CI fail to preserve code clarity
* Fix parsing of subprocess.run output for some python versions
* Make output more readable in console for list-qt-commercial
* Forward email and password to list request for users without a qtaccount.ini
* Change default settings
* Fix lint errors
* Fix check error
* Rewrite WASM support
* Add WASM tests to CI, update CI to test more the latest versions, add auto EMSDK version detection function
* Fix some mistakes, typos, moved emsdk version function into BuildJob
* Fix issue related to extensions interfering with wasm on 6.8+
* Fix tests
* Remove dep on Version in CI
* Remove safety before patch
* handle cases where extensions don't exist.
for example with windows desktop 6.8.1 win64_msvc2022_arm64_cross_compiled
both qtwebengine and qtpdf don't exist.
Signed-off-by: Alexandre 'Kidev' Poumaroux <1204936+Kidev@users.noreply.github.com>
* for --long-modules assume extension doesn't exist on download error.
Signed-off-by: Alexandre 'Kidev' Poumaroux <1204936+Kidev@users.noreply.github.com>
* for --modules assume extension doesn't exist for download failures.
Signed-off-by: Alexandre 'Kidev' Poumaroux <1204936+Kidev@users.noreply.github.com>
* reformat with black
Signed-off-by: Alexandre 'Kidev' Poumaroux <1204936+Kidev@users.noreply.github.com>
* fix flake8 regression that doesn't occur locally.
Signed-off-by: Alexandre 'Kidev' Poumaroux <1204936+Kidev@users.noreply.github.com>
* Fix autodesktop by also updating the OS when searching for a valid desktop version to download
* Fix extension issue, reduce the possible retry for getting extensions to prevent server spam
* Fix CI asking for msvc2019 on 6.8+ but its no longer supported
* Make CI use C++20 and MSVC2022
* Fix linux build
* Update runners to windows-2022
Signed-off-by: Alexandre 'Kidev' Poumaroux <1204936+Kidev@users.noreply.github.com>
* Fix patching
Signed-off-by: Alexandre 'Kidev' Poumaroux <1204936+Kidev@users.noreply.github.com>
* Add back the semantic version changes to prevent crashes, add tests for it
* Update checks
* Cast 'https://mirrors.ustc.edu.cn' to the shadow realm
* Again
* Update settings.ini
* Update settings.ini
* Update settings.ini
* Remove one_rep on silent
* Update settings.ini
* Restore master settings, remove hash check
* ci: Use specific mirror
Attempt to work around download errors in Azure due to Qt's official download site often redirecting to mirrors to which the network connection is unstable
Signed-off-by: Alexandre 'Kidev' Poumaroux <1204936+Kidev@users.noreply.github.com>
* Re enable hash checking
* Treat read timeout error during download as connection error
Signed-off-by: Alexandre 'Kidev' Poumaroux <1204936+Kidev@users.noreply.github.com>
* Add test for modules in WASM with autodesktop
* Fix format
* Fix test
* Make '--autodesktop' trigger its own install process, and test it
* Fix older autodesktop tests
* Add mock update files for 680 wasm, add test for wasm 680 autodesktop
* Passes the additional tests
* Fix format
* Improve coverage, fix format
* Fix tests and improve logging or install
* Fix format
* Fix regression in other tests
* Use flavor
* Fix line len
* Fix codeql
* Fix list-qt for WASM arch on 6.5.x and 6.6.x, restore to original download URL
* Fix test error
* Revert ci settings URL as it is never used by clients, only in CI
* Add comment for clarity in ci/settings.ini
---------
Signed-off-by: Alexandre 'Kidev' Poumaroux <1204936+Kidev@users.noreply.github.com>
Co-authored-by: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Co-authored-by: J.D. Purcell <jdpurcell@gmail.com>
- exclude .reviewdog.yml from source distribution
- Add more type hints
- protective check for self.config in SettingsClass
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* appease mypy Version no-untyped-call
Without the type hint we get:
error: Call to untyped function "Version" in typed
context [no-untyped-call]
Note that our Version is derived from semantic_version, which
doesn't have type hints.
* mark class definition __init__ functions -> None.
This prevents reviewdog from generating an no-untyped-call warning
when a new instance of the class is created. This behavior is
a time bomb. reviewdog flags the warning at the line the new instance
was added, which is within the scope of the diffs, but the problem lies
elsewhere, in the class definition.
* fix mypy import-untyped error.
* Settings: add an option to skip checksum verification on Updates.xml
This allows aqt to work even when the server download.qt.io is
unreachable.
Signed-off-by: Alberto Mardegan <mardy@users.sourceforge.net>
* Update settings.ini
* Correct option to skip checksum verification
* Rename ignore_hash option to INSECURE_NOT_FOR_PRODUCTION_ignore_hash
* Update doc about INSECURE_NOT_FOR_PRODUCTION_ignore_hash
* Add hash_algorithm option
* Unofficial mirrors might not provide any hash for Updates.xml
* docs: update configuration.rst
express default value of hash_algorithm
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* fix: hashlib constructor with usedforsecurity=False
- Python 3.9 and later introduce a keyword argument ``usedforsecurity``
- Set to False because we use hash to check file integrity not for password hash.
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
* Attempt to fix parameter type inconsistency in downloadBinaryFile
---------
Signed-off-by: Alberto Mardegan <mardy@users.sourceforge.net>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Co-authored-by: Alberto Mardegan <mardy@users.sourceforge.net>
Co-authored-by: Hiroshi Miura <miurahr@linux.com>
- Replace map+filter and list+filter with list comprehension expression
- Use try/except for next(Iterator)
- Add test case for altlink that cause exception on next() in get_altlink
- Avoid exit but use sys.exit
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- Introduce classes inherit argparse.ArgumentParser to suppress mypy
errors in Cli class.
- `requests.session.Session.get()` expects that `timeout` is `float | tuple[float, float] | tuple[float, None] | None`
so use `Tuple[float, float]` for timeout
- Use named tuple for modules_query
- Update test_list.py
Causes `get_hash` to verify the hash length, and check that the hash can
be unhexlified properly.
Fixes the interface for `get_hash` so that the caller does not have to
run `binascii.unhexlify` or verify its output.
I don't think we can really call the `Updates.xml` files that we are
parsing 'untrusted xml', because we are checking that they match the
sha256 checksum. However, I don't think there's any good reason not to
use a more secure parsing algorithm.
aqt.helper.MyConfigParser.getlist fails to retrieve a fallback list when
the `section` parameter does not exist in the `settings.ini` file.
This ensures that the fallback is used when that key is missing.
To keep this commit small, `hashurl` was removed from QtPackage, and
`get_hash` constructs the hash url based on the url of the 7z archive
to download. I think that in the future, QtArchive and QtPackage could
be refactored to construct this url more appropriately. However, this
would be a complicated change that doesn't belong in this commit.
getUrl() now use `requests.get()` that is default getter that does not retry.
This change corrects it to `session.get()`
Related issue #472
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
This prevents `list-*` from printing any module whose uncompressed size
is 40 bytes or less.
I have found a couple of modules that are exactly 40 bytes, and they
include no files, only empty directories. If any user tries to install
these modules, they will think that aqt failed to install the module
without printing any error message. I prefer to avoid this issue
by preventing `aqt list-*` from printing them.
`aqt install-*` is unaffected by this change, and it can still install
modules that contain no files. It is likely that we will need to print
a warning when this occurs.
If any user disagrees with the threshold value of 40 bytes, they are
free to adjust that value to their liking in `settings.ini`.
This allows a user to turn on `--keep` every time they run the program,
and to set the default archive destination when `--keep` is turned on.
Using `--archive-dest` overrides the archive destination in setting.ini.
This adds the parameter `archive_dest` to `run_installer`, which will
control where `helper.downloadBinaryFile` will download files, and sets
it to "." by default.
For convenience/readability, this will also turn any reference to the
downloaded file into a `pathlib.Path` object. This makes it easier to
ensure that the file ends up in the right location.
This change deprecates the `max_retries` option in settings.ini,
replacing it with `max_retries_on_connection_error`, in order to
differentiate it from `max_retries_on_checksum_error`.
This change separates the handling of hash mismatches from all other
exceptions.
The functions in the `try` block (open, iter_content, write, update,
flush) can generate a wide variety of exceptions with no common base
class other than Exception. It would be my preference to differentiate
between file IO exceptions, hash update errors, and input stream errors,
but it seems impractical to track down all the different types. For that
reason, I am wrapping the base Exception type in an
ArchiveDownloadError. I am removing the `exc=sys.exc_info()` and
`logger.error(exc[1])` because it's redundant. `sys.exc_info()[1]`
returns the current exception being handled, which is `e`.
