Use concurrent.futures for concurrency with thread and process (#87)

Use concurrent.futures for multiprocessing and other improvements
- combination with thread pool for downloading and  process pool for extraction.
- Iterate all download and start extraction.
- Start extraction when download completed
- Add download completion log
- log a time  when extraction done
- Show elasped time for installation
- Meature elasped time
  * use perf_counter() for a total elapsed time.
  * use process_time() for individual extractions.

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

* fix format specifier

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
This commit is contained in:
Hiroshi Miura
2020-02-11 10:42:46 +09:00
committed by GitHub
parent ab6ceaf58a
commit bbb39c0847
3 changed files with 108 additions and 57 deletions

View File

@@ -1,7 +1,7 @@
#!/usr/bin/env python
#
# Copyright (C) 2018 Linus Jahn <lnj@kaidan.im>
# Copyright (C) 2019 Hiroshi Miura <miurahr@linux.com>
# Copyright (C) 2019, 2020 Hiroshi Miura <miurahr@linux.com>
#
# Permission is hereby granted, free of charge, to any person obtaining a copy of
# this software and associated documentation files (the "Software"), to deal in

View File

@@ -24,7 +24,7 @@ import argparse
import logging
import logging.config
import os
import sys
import time
from packaging.version import Version, parse
@@ -100,6 +100,7 @@ class Cli():
return all([m in available for m in modules])
def run_install(self, args):
start_time = time.perf_counter()
arch = args.arch
target = args.target
os_name = args.host
@@ -119,11 +120,11 @@ class Cli():
self.logger.warning("Some of specified modules are unknown.")
QtInstaller(QtArchives(os_name, target, qt_version, arch, modules=modules, mirror=mirror, logging=self.logger,
all_extra=all_extra),
logging=self.logger).install(command=sevenzip, target_dir=output_dir)
sys.stdout.write("\033[K")
print("Finished installation")
logging=self.logger, command=sevenzip, target_dir=output_dir).install()
self.logger.info("Time elasped: {time:.8f} second".format(time=time.perf_counter() - start_time))
def run_tool(self, args):
start_time = time.perf_counter()
arch = args.arch
tool_name = args.tool_name
os_name = args.host
@@ -135,9 +136,8 @@ class Cli():
if not self._check_tools_arg_combination(os_name, tool_name, arch):
self.logger.warning("Specified target combination is not valid: {} {} {}".format(os_name, tool_name, arch))
QtInstaller(ToolArchives(os_name, tool_name, version, arch, mirror=mirror, logging=self.logger),
logging=self.logger).install(command=sevenzip, target_dir=output_dir)
sys.stdout.write("\033[K")
print("Finished installation")
logging=self.logger, command=sevenzip, target_dir=output_dir).install()
self.logger.info("Time elasped: {time:.8f} second".format(time=time.perf_counter() - start_time))
def run_list(self, args):
print('List Qt packages for %s' % args.qt_version)

View File

@@ -1,7 +1,7 @@
#!/usr/bin/env python3
#
# Copyright (C) 2018 Linus Jahn <lnj@kaidan.im>
# Copyright (C) 2019-2020 Hiroshi Miura <miurahr@linux.com>
# Copyright (C) 2019,2020 Hiroshi Miura <miurahr@linux.com>
#
# Permission is hereby granted, free of charge, to any person obtaining a copy of
# this software and associated documentation files (the "Software"), to deal in
@@ -20,20 +20,20 @@
# IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
# CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
import concurrent.futures
import functools
import os
import subprocess
import time
from logging import getLogger
from multiprocessing.dummy import Pool
from operator import and_
from subprocess import run
from time import sleep
import requests
import py7zr
from aqt.helper import altlink
NUM_PROCESS = 3
class BadPackageFile(Exception):
pass
@@ -44,17 +44,21 @@ class QtInstaller:
Installer class to download packages and extract it.
"""
def __init__(self, qt_archives, logging=None):
def __init__(self, qt_archives, logging=None, command=None, target_dir=None):
self.qt_archives = qt_archives
if logging:
self.logger = logging
else:
self.logger = getLogger('aqt')
self.command = command
if target_dir is None:
self.base_dir = os.getcwd()
else:
self.base_dir = target_dir
def retrieve_archive(self, package, path=None, command=None):
def retrieve_archive(self, package):
archive = package.archive
url = package.url
self.logger.info("-Downloading {}...".format(url))
try:
r = requests.get(url, allow_redirects=False, stream=True)
if r.status_code == 302:
@@ -64,41 +68,87 @@ class QtInstaller:
r = requests.get(newurl, stream=True)
except requests.exceptions.ConnectionError as e:
self.logger.warning("Caught download error: %s" % e.args)
return False
return None
else:
try:
with open(archive, 'wb') as fd:
for chunk in r.iter_content(chunk_size=8196):
fd.write(chunk)
self.logger.info("-Extracting {}...".format(archive))
except Exception as e:
self.logger.warning("Caught download error: %s" % e.args)
return None
return archive
if not py7zr.is_7zfile(archive):
raise BadPackageFile
if command is None:
py7zr.SevenZipFile(archive).extractall(path=path)
else:
if path is not None:
run([command, 'x', '-aoa', '-bd', '-y', '-o{}'.format(path), archive])
else:
run([command, 'x', '-aoa', '-bd', '-y', archive])
def extract_archive(self, archive):
py7zr.SevenZipFile(archive).extractall(path=self.base_dir)
os.unlink(archive)
return True
return archive, time.process_time()
def install(self, command=None, target_dir=None):
qt_version, target, arch = self.qt_archives.get_target_config()
if target_dir is None:
base_dir = os.getcwd()
def extract_archive_ext(self, archive):
if self.base_dir is not None:
subprocess.run([self.command, 'x', '-aoa', '-bd', '-y', '-o{}'.format(self.base_dir), archive])
else:
base_dir = target_dir
subprocess.run([self.command, 'x', '-aoa', '-bd', '-y', archive])
os.unlink(archive)
return archive, 0
def install(self):
qt_version, target, arch = self.qt_archives.get_target_config()
if self.command is None:
extractor = self.extract_archive
else:
extractor = self.extract_archive_ext
archives = self.qt_archives.get_archives()
p = Pool(NUM_PROCESS)
ret_arr = p.map(functools.partial(self.retrieve_archive, command=command, path=base_dir), archives)
ret = functools.reduce(and_, ret_arr)
if not ret: # fails to install
self.logger.error("Failed to install.")
# retrieve files from download site
with concurrent.futures.ProcessPoolExecutor() as pexec:
download_task = []
completed_downloads = []
extract_task = []
completed_extract = []
with concurrent.futures.ThreadPoolExecutor() as texec:
for ar in archives:
self.logger.info("Downloading {}...".format(ar.url))
download_task.append(texec.submit(self.retrieve_archive, ar))
completed_downloads.append(False)
completed_extract.append(False)
while True:
for i, t in enumerate(download_task):
if completed_downloads[i]:
if not completed_extract[i] and i < len(extract_task) and extract_task[i].done():
(archive, elapsed) = extract_task[i].result()
self.logger.info("Done {} extraction in {:.8f}.".format(archive, elapsed))
completed_extract[i] = True
elif t.done():
archive = t.result()
if archive is None:
self.logger.error("Failed to download.")
exit(1)
if qt_version == "Tools": # tools installation
return
self.logger.info("Extracting {}...".format(archive))
extract_task.append(pexec.submit(extractor, archive))
completed_downloads[i] = True
if functools.reduce(and_, completed_downloads):
self.logger.info("Downloads are Completed.")
break
else:
for i, t in enumerate(extract_task):
if not completed_extract[i] and t.done():
(archive, elapsed) = t.result()
self.logger.info("Done {} extraction in {:.8f}.".format(archive, elapsed))
completed_extract[i] = True
sleep(0.05)
while True:
for i, t in enumerate(extract_task):
if not completed_extract[i] and t.done():
(archive, elapsed) = t.result()
self.logger.info("Done {} extraction in {:.8f}.".format(archive, elapsed))
completed_extract[i] = True
if functools.reduce(and_, completed_extract):
break
else:
sleep(0.5)
# finalize
if qt_version != "Tools": # tools installation
if arch.startswith('win64_mingw'):
arch_dir = arch[6:] + '_64'
elif arch.startswith('win32_mingw'):
@@ -107,17 +157,18 @@ class QtInstaller:
arch_dir = arch[6:]
else:
arch_dir = arch
self.make_conf_files(base_dir, qt_version, arch_dir)
self.make_conf_files(qt_version, arch_dir)
self.logger.info("Finished installation")
def make_conf_files(self, base_dir, qt_version, arch_dir):
def make_conf_files(self, qt_version, arch_dir):
"""Make Qt configuration files, qt.conf and qtconfig.pri"""
try:
# prepare qt.conf
with open(os.path.join(base_dir, qt_version, arch_dir, 'bin', 'qt.conf'), 'w') as f:
with open(os.path.join(self.base_dir, qt_version, arch_dir, 'bin', 'qt.conf'), 'w') as f:
f.write("[Paths]\n")
f.write("Prefix=..\n")
# update qtconfig.pri only as OpenSource
with open(os.path.join(base_dir, qt_version, arch_dir, 'mkspecs', 'qconfig.pri'), 'r+') as f:
with open(os.path.join(self.base_dir, qt_version, arch_dir, 'mkspecs', 'qconfig.pri'), 'r+') as f:
lines = f.readlines()
f.seek(0)
f.truncate()