Mirrors/aqtinstall
1
0
Fork 0
mirror of https://github.com/miurahr/aqtinstall.git synced 2025-12-18 05:04:38 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix implementation of aqt tool

Browse Source 
This modifies `aqt tool` to allow `-` characters in tool versions, so
that `aqt tool` can pass the same unit tests that `install-tool` can.
This makes it less like the `aqt tool` from v1.2.5, but it should work
better with more tools with different version formats.
This commit is contained in:
David Dalcino
2021-10-30 19:22:34 -07:00
parent 7638d87d6c
commit 621cd7a6c0
3 changed files with 40 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/test_cli.py
View File

@@ -150,6 +150,28 @@ def test_cli_invalid_version(capsys, invalid_version):
assert matcher.match(err)
@pytest.mark.parametrize(
"version, allow_latest, allow_empty, allow_minus, expect_ok",
(
("1.2.3", False, False, False, True),
("1.2.", False, False, False, False),
("latest", True, False, False, True),
("latest", False, False, False, False),
("", False, True, False, True),
("", False, False, False, False),
("1.2.3-0-123", False, False, True, True),
("1.2.3-0-123", False, False, False, False),
),
)
def test_cli_validate_version(version: str, allow_latest: bool, allow_empty: bool, allow_minus: bool, expect_ok: bool):
if expect_ok:
Cli._validate_version_str(version, allow_latest=allow_latest, allow_empty=allow_empty, allow_minus=allow_minus)
else:
with pytest.raises(CliInputError) as err:
Cli._validate_version_str(version, allow_latest=allow_latest, allow_empty=allow_empty, allow_minus=allow_minus)
assert err.type == CliInputError
def test_cli_check_mirror():
cli = Cli()
cli._setup_settings()