From e238597f6c73bdf7b1e8d5a948b8d2ea10503b8f Mon Sep 17 00:00:00 2001 From: Alexolut Date: Wed, 25 Nov 2015 11:19:08 +0300 Subject: [PATCH] fixed a typos because of zero-based indexing Another misunderstanding: how container can be modified (side-effect in a call of `f(&v[i])` ) if we passing only an address to element, not a address to container? --- CppCoreGuidelines.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index f7437e0..ff6cdd1 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -8247,10 +8247,10 @@ Readability. Error prevention. Efficiency. for (int i = 1; i < v.size(); ++i) // touches two elements: can't be a range-for cout << v[i] + v[i-1] << '\n'; - for (int i = 1; i < v.size(); ++i) // possible side-effect: can't be a range-for + for (int i = 0; i < v.size(); ++i) // possible side-effect: can't be a range-for cout << f(&v[i]) << '\n'; - for (int i = 1; i < v.size(); ++i) { // body messes with loop variable: can't be a range-for + for (int i = 0; i < v.size(); ++i) { // body messes with loop variable: can't be a range-for if (i % 2) ++i; // skip even elements else