Mirrors/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2025-12-18 13:14:40 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

wrong sample class

Browse Source
This commit is contained in:
Thibault Kruse
2016-08-11 17:18:50 +02:00
parent 01b66d9a7e
commit dc683521ee
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
CppCoreGuidelines.md
View File

@@ -4169,7 +4169,7 @@ Note that if you define a destructor, you must define or delete [all default ope
~Smart_ptr2() { delete p; } // p is an owner! ~Smart_ptr2() { delete p; } // p is an owner!
}; };
void use(Smart_ptr<int> p1) void use(Smart_ptr2<int> p1)
{ {
auto p2 = p1; // error: double deletion auto p2 = p1; // error: double deletion
} }
@@ -4440,8 +4440,8 @@ The C++11 initializer list rule eliminates the need for many constructors. For e
Rec2(const string& ss, int ii = 0) :s{ss}, i{ii} {} // redundant Rec2(const string& ss, int ii = 0) :s{ss}, i{ii} {} // redundant
}; };
Rec r1 {"Foo", 7}; Rec2 r1 {"Foo", 7};
Rec r2 {"Bar"}; Rec2 r2 {"Bar"};
The `Rec2` constructor is redundant. The `Rec2` constructor is redundant.
Also, the default for `int` would be better done as a [member initializer](#Rc-in-class-initializer). Also, the default for `int` would be better done as a [member initializer](#Rc-in-class-initializer).