From d1def3290cf91bebfbc9c969a153d626043acec7 Mon Sep 17 00:00:00 2001 From: hsutter Date: Mon, 13 Aug 2018 11:18:52 -0700 Subject: [PATCH] Tweaked PR 1249 post-merge to cover copy assignment too --- CppCoreGuidelines.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index bdfa7d3..464f598 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -1,6 +1,6 @@ # C++ Core Guidelines -April 16, 2018 +August 13, 2018 Editors: @@ -6505,7 +6505,7 @@ Designing rules for classes in a hierarchy summary: * [C.127: A class with a virtual function should have a virtual or protected destructor](#Rh-dtor) * [C.128: Virtual functions should specify exactly one of `virtual`, `override`, or `final`](#Rh-override) * [C.129: When designing a class hierarchy, distinguish between implementation inheritance and interface inheritance](#Rh-kind) -* [C.130: For making deep copies of polymorphic classes prefer a virtual `clone` function to copy constructor](#Rh-copy) +* [C.130: For making deep copies of polymorphic classes prefer a virtual `clone` function instead of copy construction/assignment](#Rh-copy) * [C.131: Avoid trivial getters and setters](#Rh-get) * [C.132: Don't make a function `virtual` without reason](#Rh-virtual) * [C.133: Avoid `protected` data](#Rh-protected) @@ -7000,7 +7000,7 @@ at the cost of the functionality being available only to users of the hierarchy. * ??? -### C.130: For making deep copies of polymorphic classes prefer a virtual `clone` function to copy constructor +### C.130: For making deep copies of polymorphic classes prefer a virtual `clone` function instead of copy construction/assignment ##### Reason