From b4260e6fa90a5bea2539e042801867c3bad84eaf Mon Sep 17 00:00:00 2001 From: Gabriel Dos Reis Date: Sat, 12 Dec 2015 21:36:11 -0800 Subject: [PATCH] Fix data member names Rename `fx` to `x`, `fy` to `y`, `fz` to `z`, and `fe` to `e` to match names used in the narative and other member function. Fix pull request #456. --- CppCoreGuidelines.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index d9cef62..c7c34d4 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -765,10 +765,13 @@ There are cases where checking early is dumb because you may not ever need the v class Jet { // Physics says: e*e < x*x + y*y + z*z - float fx, fy, fz, fe; + float x; + float y; + float z; + float e; public: Jet(float x, float y, float z, float e) - :fx(x), fy(y), fz(z), fe(e) + :x(x), y(y), z(z), e(e) { // Should I check here that the values are physically meaningful? }