Mirrors/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2025-12-17 04:44:34 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #955 from codeboost/patch-3

Browse Source 
C.133 - Grammar/semantic issues fixed
This commit is contained in:
Gabriel Dos Reis
2017-06-08 05:17:36 -07:00
committed by GitHub
parent 906ae347f3 d4d48ec772
commit a8377b9302
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
CppCoreGuidelines.md
View File

@@ -6965,8 +6965,8 @@ This kind of "vector" isn't meant to be used as a base class at all.
##### Reason ##### Reason
`protected` data is a source of complexity and errors. `protected` data is a source of complexity and errors.
`protected` data complicated the statement of invariants. `protected` data complicates the statement of invariants.
`protected` data inherently violates the guidance against putting data in base classes, which usually leads to having to deal virtual inheritance as well. `protected` data inherently violates the guidance against putting data in base classes, which usually leads to having to deal with virtual inheritance as well.
##### Example, bad ##### Example, bad
@@ -6985,7 +6985,7 @@ This has been popular, but also a major source of maintenance problems.
In a large class hierarchy, the consistent use of protected data is hard to maintain because there can be a lot of code, In a large class hierarchy, the consistent use of protected data is hard to maintain because there can be a lot of code,
spread over a lot of classes. spread over a lot of classes.
The set of classes that can touch that data is open: anyone can derive a new class and start manipulating the protected data. The set of classes that can touch that data is open: anyone can derive a new class and start manipulating the protected data.
Often, it is not possible to examine the complete set of classes so any change to the representation of the class becomes infeasible. Often, it is not possible to examine the complete set of classes, so any change to the representation of the class becomes infeasible.
There is no enforced invariant for the protected data; it is much like a set of global variables. There is no enforced invariant for the protected data; it is much like a set of global variables.
The protected data has de facto become global to a large body of code. The protected data has de facto become global to a large body of code.