From d084dcef3166833e7ce8c14ad5f8b980f63d2d60 Mon Sep 17 00:00:00 2001 From: Robin Degen Date: Tue, 26 Jul 2016 07:33:57 +0200 Subject: [PATCH 1/3] Fixed typo shuld -> should, fixed missing words --- CppCoreGuidelines.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index 1c92c21..42632f1 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -15806,7 +15806,7 @@ In the context of the styles of programming we recommend and support with the gu Non-rule summary: -* [NR.1: All declarations should be at the of a function](#Rnr-top) +* [NR.1: All declarations should be at the top of a function](#Rnr-top) * single-return rule * no exceptions * one class per source file @@ -15815,7 +15815,7 @@ Non-rule summary: * make all data members `protected` * ??? -### NR.1: All declarations should be at the of a function +### NR.1: All declarations should be at the top of a function ##### Reason From 04cd9a5d73bda71d79526866c669e71d10ad3e74 Mon Sep 17 00:00:00 2001 From: Passw Date: Wed, 3 Aug 2016 15:21:37 +0800 Subject: [PATCH 2/3] fix typo --- CppCoreGuidelines.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index 42632f1..2a59af1 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -654,7 +654,7 @@ Also, it is implicit that `f2()` is supposed to `delete` its argument (or did th The standard library resource management pointers fail to pass the size when they point to an object: // separately compiled, possibly dynamically loaded - // NB: this assumes the calling code is A BI-compatible, using a + // NB: this assumes the calling code is ABI-compatible, using a // compatible C++ compiler and the same stdlib implementation extern void f3(unique_ptr, int n); From 9f2d2645ff95d146a8f57f22d38ba0e10a56e8bb Mon Sep 17 00:00:00 2001 From: Sam Bristow Date: Tue, 26 Jul 2016 16:56:42 +1200 Subject: [PATCH 3/3] Remove rogue comma from example --- CppCoreGuidelines.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index 2a59af1..77860cb 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -7458,7 +7458,7 @@ Such code is not uncommon in code written before there were convenient alternati Use `constexpr` values instead. For example: - constexpr int red = 0x,FF0000; + constexpr int red = 0xFF0000; constexpr short scale = 4; constexpr bool signed = true;