Mirrors/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2025-12-17 12:44:42 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix example good in ES.42, count to a.size() (#1245)

Browse Source 
* Fix example good in ES.42, count to a.size()

* Fix typos in ES.64 and Con.1

* Fix Example bad in T.3, no value in subscript
This commit is contained in:
martysama0134
2018-08-06 17:06:32 +02:00
committed by Herb Sutter
parent 6dd14321c1
commit 513a5fd624
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
CppCoreGuidelines.md
View File

@@ -10953,7 +10953,7 @@ Access into an array with known bounds using a constant as a subscript can be va
a[4] = 1; // OK a[4] = 1; // OK
a[count - 1] = 2; // OK a[a.size() - 1] = 2; // OK
use(a.data(), 3); // OK use(a.data(), 3); // OK
} }
@@ -11824,7 +11824,7 @@ For built-in types, the construction notation protects against narrowing and rei
int y1 = int(ch); // OK, but redundant int y1 = int(ch); // OK, but redundant
int y2 = int(d); // bad: double->int narrowing; use a cast if you need to int y2 = int(d); // bad: double->int narrowing; use a cast if you need to
int y3 = int(p); // bad: pointer to->int; use a reinterpret_cast if you really need to int y3 = int(p); // bad: pointer to->int; use a reinterpret_cast if you really need to
int y4 = int(lng); // bad: long->int narrowing; use a cast if you need to int y4 = int(lng); // bad: long long->int narrowing; use a cast if you need to
int z1 = (int)ch; // OK, but redundant int z1 = (int)ch; // OK, but redundant
int z2 = (int)d; // bad: double->int narrowing; use a cast if you need to int z2 = (int)d; // bad: double->int narrowing; use a cast if you need to
@@ -15902,7 +15902,7 @@ Example:
void f(int* p); // old code: f() does not modify `*p` void f(int* p); // old code: f() does not modify `*p`
void f(const int* p) { f(const_cast<int*>(p)); } // wrapper void f(const int* p) { f(const_cast<int*>(p)); } // wrapper
Note that this wrapper solution is a patch that should be used only when the declaration of `f()` cannot be be modified, Note that this wrapper solution is a patch that should be used only when the declaration of `f()` cannot be modified,
e.g. because it is in a library that you cannot modify. e.g. because it is in a library that you cannot modify.
##### Note ##### Note
@@ -16244,7 +16244,7 @@ It also avoids brittle or inefficient workarounds. Convention: That's the way th
}; };
Container c(10, sizeof(double)); Container c(10, sizeof(double));
((double*) c.elem)[] = 9.9; ((double*) c.elem)[7] = 9.9;
This doesn't directly express the intent of the programmer and hides the structure of the program from the type system and optimizer. This doesn't directly express the intent of the programmer and hides the structure of the program from the type system and optimizer.