From 4c35d4c022f52806394401c48691f8277a3e216e Mon Sep 17 00:00:00 2001 From: jkorinth Date: Tue, 28 May 2019 17:11:33 +0200 Subject: [PATCH] Fix C.120 good example (#1426) C.120 has a good example which violates C.128 by specifying both virtual and override for methods. closes #1425 --- CppCoreGuidelines.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index 145d201..50aa89f 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -6788,8 +6788,8 @@ Do *not* use inheritance when simply having a data member will do. Usually this }; class PushButton : public AbstractButton { - virtual void render() const override; - virtual void onClick() override; + void render() const override; + void onClick() override; // ... };