From 4b8b2819b98c45b5ad22092a432da72bbf00bc79 Mon Sep 17 00:00:00 2001 From: Sergey Zubkov Date: Wed, 13 Jul 2022 14:19:39 -0400 Subject: [PATCH] C.32: amend merged PR per call notes. It overlaps R.3 quite a bit --- CppCoreGuidelines.md | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index 233a6e7..9b9d12e 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -1,6 +1,6 @@ # C++ Core Guidelines -June 13, 2022 +July 13, 2022 Editors: @@ -4994,17 +4994,16 @@ There is a lot of code that is non-specific about ownership. class legacy_class { - foo* m_owning; - bar* m_observer; + foo* m_owning; // Bad: change to unique_ptr or owner + bar* m_observer; // OK: keep } -The only way to determine ownership may be to dig through the code to look for -allocations. If a pointer or reference is owning, document it as owning. +The only way to determine ownership may be code analysis. ##### Note -Ownership should be clear in new code (and refactored legacy code) according to [R.20](#Rr-owner) for owned -pointers and [R.3](#Rr-ptr) for non-owned pointers. References should never own [R.4](#Rr-ref). +Ownership should be clear in new code (and refactored legacy code) according to [R.20](#Rr-owner) for owning +pointers and [R.3](#Rr-ptr) for non-owning pointers. References should never own [R.4](#Rr-ref). ##### Enforcement