Merge pull request #694 from tkruse/merge-leftovers

Bad Merge leftovers
This commit is contained in:
Andrew Pardoe
2016-08-22 18:00:04 -07:00
committed by GitHub
4 changed files with 10 additions and 31 deletions

View File

@@ -5464,7 +5464,7 @@ The compiler is more likely to get the default semantics right and you cannot im
Tracer& operator=(Tracer&&) = default;
};
Because we defined the destructor, we must define the copy and move operations. The `=default` is the best and simplest way of doing that.
Because we defined the destructor, we must define the copy and move operations. The `= default` is the best and simplest way of doing that.
##### Example, bad
@@ -7484,7 +7484,7 @@ The default is the easiest to read and write.
enum class Direction : char { n, s, e, w,
ne, nw, se, sw }; // underlying type saves space
enum class Web_color : int { red = 0xFF0000,
green = 0x00FF00,
blue = 0x0000FF }; // underlying type is redundant
@@ -12180,10 +12180,10 @@ Not all member functions can be called.
##### Example
class Vector { // very simplified vector of doubles
// if elem!=nullptr then elem points to sz doubles
// if elem != nullptr then elem points to sz doubles
public:
Vector() : elem{nullptr}, sz{0}{}
vector(int s) : elem{new double},sz{s} { /* initialize elements */ }
vector(int s) : elem{new double}, sz{s} { /* initialize elements */ }
~Vector() { delete elem; }
double& operator[](int s) { return elem[s]; }
// ...
@@ -16200,7 +16200,7 @@ Note that a C-style `(T)expression` cast means to perform the first of the follo
};
Derived1 d1;
Base* p = &d1; // ok, implicit conversion to pointer to Base is fine
Base* p1 = &d1; // ok, implicit conversion to pointer to Base is fine
// BAD, tries to treat d1 as a Derived2, which it is not
Derived2* p2 = (Derived2*)(p);